Repository navigation
Conversation
Fix H3-PROXY receive flow control to properly account for the data buffered and update windows on buffer consumption.
bagder
approved these changes
Sep 22, 2026
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One receive path still fails to restore flow-control credit, and the HTTP/2 test lacks its required feature guard.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Fixes HTTP/3 proxy receive flow control by tying QUIC window updates to tunnel-buffer capacity.
Changes:
- Adds a 512 KiB tunnel receive-window limit.
- Updates flow-control credit after buffer consumption.
- Exercises parallel HTTP/2 downloads through an HTTP/3 proxy.
| File | Description |
|---|---|
lib/vquic/cf-ngtcp2-proxy.c |
Revises tunnel receive buffering and window updates. |
lib/vquic/cf-ngtcp2-cmn.h |
Removes obsolete window tracking. |
lib/vquic/cf-ngtcp2-cmn.c |
Removes initialization of that field. |
tests/http/test_60_h3_proxy.py |
Changes the parallel-download test to HTTP/2. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix H3-PROXY receive flow control to properly account for the data buffered and update windows on buffer consumption.
reported-by: Joshua Rogers & The Clankers