Repository navigation
Conversation
curl_url_dup() copied port_present, fragment_present and query_present but missed guessed_scheme, so a duplicated handle always reported an explicit scheme. Applications relying on CURLU_GUESS_SCHEME plus CURLU_NO_GUESS_SCHEME to reject bare hostnames after duplicating a handle would silently accept them instead. Verified in test 1989 Reported-by: Joshua Rogers
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused fix correctly preserves URL state and includes appropriate regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Ensures duplicated URL handles retain whether their scheme was guessed.
Changes:
- Copies
guessed_schemeincurl_url_dup(). - Adds and registers regression test 1989.
| File | Description |
|---|---|
lib/urlapi.c |
Preserves the guessed-scheme flag during duplication. |
tests/libtest/lib1989.c |
Tests duplication behavior. |
tests/libtest/Makefile.inc |
Registers the libtest source. |
tests/data/test1989 |
Defines the regression test case. |
tests/data/Makefile.am |
Registers test 1989. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curl_url_dup() copied port_present, fragment_present and query_present but missed guessed_scheme, so a duplicated handle always reported an explicit scheme. Applications relying on CURLU_GUESS_SCHEME plus CURLU_NO_GUESS_SCHEME to reject bare hostnames after duplicating a handle would silently accept them instead.
Verified in test 1989
Reported-by: Joshua Rogers