Repository navigation
Conversation
On platforms that require keepalive times in milliseconds (Windows before 10.0.16299, Solaris before 11.4, DragonFlyBSD before 500702), curl converts seconds to milliseconds and starting now it prevents that multiplication from doing an integer overflow. If too large value is set, INT_MAX millisconds is used. Reported-by: Joshua Rogers
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The exact highest safely convertible value is incorrectly clamped.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Clamps keepalive second-to-millisecond conversions to prevent integer overflow on legacy platforms.
Changes:
- Replaces unchecked multiplication with saturating conversion.
- Applies conversion consistently across keepalive socket options.
| File | Description |
|---|---|
lib/cf-socket.c |
Adds overflow-safe keepalive unit conversion. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On platforms that require keepalive times in milliseconds (Windows before 10.0.16299, Solaris before 11.4, DragonFlyBSD before 500702), curl converts seconds to milliseconds and starting now it prevents that multiplication from doing an integer overflow. If too large value is set, INT_MAX millisconds is used.
Reported-by: Joshua Rogers