fix build with versions of OpenSSL < 0.9.8 #2305

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@dougmencken
Contributor

dougmencken commented Feb 12, 2018

support for SHA-2 was introduced in OpenSSL 0.9.8

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Feb 12, 2018

Member

The CURL_SHA256_OPENSSL symbol is already used so this conflicts and causes the CI failures. Maybe USE_OPENSSL_SHA256 ?

Member

bagder commented Feb 12, 2018

The CURL_SHA256_OPENSSL symbol is already used so this conflicts and causes the CI failures. Maybe USE_OPENSSL_SHA256 ?

fix build with versions of OpenSSL < 0.9.8
support for SHA-2 was introduced in OpenSSL 0.9.8
@dougmencken

This comment has been minimized.

Show comment
Hide comment
@dougmencken

dougmencken Feb 12, 2018

Contributor

Sure

Contributor

dougmencken commented Feb 12, 2018

Sure

@dougmencken

This comment has been minimized.

Show comment
Hide comment
@dougmencken

dougmencken Feb 12, 2018

Contributor

dougmencken@d256f5d

And I dunno how to update this request without opening the new one

Contributor

dougmencken commented Feb 12, 2018

dougmencken@d256f5d

And I dunno how to update this request without opening the new one

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Feb 12, 2018

Member

You can just commit a new commit and push that. Or amend the previous commit and "push -f" on this branch.

Member

bagder commented Feb 12, 2018

You can just commit a new commit and push that. Or amend the previous commit and "push -f" on this branch.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Feb 12, 2018

Member

But I can just get the patch you have there, no worries.

Member

bagder commented Feb 12, 2018

But I can just get the patch you have there, no worries.

@bagder bagder closed this in 50c0033 Feb 12, 2018

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Feb 12, 2018

Member

Thanks!

Member

bagder commented Feb 12, 2018

Thanks!

@curl curl locked as resolved and limited conversation to collaborators May 13, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.