Repository navigation
Conversation
Previously, passing a NULL pointer to curl_url_dup() caused a NULL pointer dereference crash on in->scheme inside the DUP() macro. Return NULL immediately when !in, matching curl_easy_duphandle() and preventing unexpected crashes when duplicating uninitialized or failed handles. Also verify this behavior in test 1560 and update documentation.
|
Analysis of PR #23051 at fc806f09: Test ../../tests/http/test_40_socks.py::TestSocks::test_40_03_dl_serial[h2-socks5] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Generated by Testclutch |
bagder
approved these changes
Sep 23, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a
NULLhandle tocurl_url_dup()caused aNULLpointer dereference crash inside theDUP()macro when evaluating(in)->scheme.Return
NULLimmediately if!inis passed, matchingcurl_easy_duphandle()and preventing crashes when duplicating uninitialized or failed handles.Also verify this in
test1560and updatecurl_url_dup(3).