Repository navigation
Conversation
When a "connect-to" only changes the port, preserve the ipv6 relevant properties like zone and scope. (Note to clankers: I do *not* plan to write a test case for this.)
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Add regression coverage for preserving IPv6 zone and scope properties.
Review effort: Lite
Findings: None
What changed in this PR
This PR preserves IPv6 zone and scope metadata when connect-to changes only the port.
Changes:
- Detects port-only remapping.
- Copies IPv6 zone and scope properties.
| File | Summary |
|---|---|
lib/peer.c |
Preserves IPv6 metadata during port-only connect-to handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bagder
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a "connect-to" only changes the port, preserve the ipv6 relevant properties like zone and scope.
(Note to clankers: I do not plan to write a test case for this.)
reported-by: Joshua Rogers & The Clankers