Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The regression tests can fail when the host has interfaces named tada or 123x.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Fixes IPv6 zone ID parsing so numeric scope IDs require an entirely numeric value.
Changes:
- Require complete numeric zone ID parsing.
- Add numeric and mixed zone ID regression tests.
| File | Review |
|---|---|
tests/unit/unit2413.c |
Adds scope ID tests, but named-zone assertions are host-dependent and must account for if_nametoindex(). |
lib/peer.c |
Validates the complete zone ID before assigning a numeric scope ID. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
When interpreting a zoneid as a numeric scopeid, check that the complete zoneid is numeric and not only has a number prefix.
icing
force-pushed
the
peer-scopeid-num-prefix-check
branch
from
September 24, 2026 11:22
c4c65a0 to
778bed3
Compare
bagder
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When interpreting a zoneid as a numeric scopeid, check that the complete zoneid is numeric and not only has a number prefix.
reported-by: Joshua "The Hat" Rogers