Repository navigation
Conversation
When using gnutls in QUIC and peer verification fails, remove the early return so that sessions for this peer are removed from the ssl session cache. reported-by: Joshua Rogers
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change correctly preserves the verification error while allowing shared cleanup to run.
Review effort: Balanced
Findings: None
What changed in this PR
Ensures GnuTLS QUIC verification failures invalidate cached TLS sessions before returning the error.
Changes:
- Routes GnuTLS verification failures through shared session-cache cleanup.
| File | Description |
|---|---|
lib/vquic/vquic-tls.c |
Removes the premature return that bypassed cache cleanup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bagder
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using gnutls in QUIC and peer verification fails, remove the early return so that sessions for this peer are removed from the ssl session cache.
reported-by: Joshua Rogers