Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Four moderate portability, cleanup, and test-reliability issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Makes stdin non-blocking so TELNET transfers can time out while awaiting input.
Changes:
- Enables non-blocking stdin for all transfers.
- Updates test 1548 to exercise idle TELNET stdin.
| File | Review |
|---|---|
src/tool_operate.c |
Three moderate issues: stdin flags are not restored; native Windows stdin remains blocking; and EWOULDBLOCK is not handled alongside EAGAIN. |
tests/data/test1548 |
Moderate issue: inherited stdin may be EOF, so the test does not reliably exercise blocking input. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
When doing TELNET:// transfers are read from stdin without having set an upload file, so set stdin non-blocking mode unconditionally to make it able to time-out correctly. Update test 1548 to sit waiting on an idle stdin with telnet properly.
bagder
force-pushed
the
bagder/stdin-nonblock
branch
from
September 24, 2026 15:34
cf9feee to
001f2dd
Compare
Member
Author
bagder
marked this pull request as ready for review
September 24, 2026 15:43
jay
added a commit
that referenced
this pull request
Sep 29, 2026
This reverts commit d745b13. Setting stdin as non-blocking unconditionally caused it to affect future shell commands. There is probably a way to fix it but I think this needs a rethink. For now we revert. Ref: #23057 Ref: #23081 Reported-by: Daniel S. Roche Researched-by: KayanoLiam@users.noreply.github.com Fixes #23127 Closes #23144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing TELNET:// transfers are read from stdin without having set an upload file, so set stdin non-blocking mode unconditionally to make it able to time-out correctly.
Update test 1548 to sit waiting on an idle stdin with telnet properly.