Repository navigation
Conversation
A write function is allowed to invoked curl_easy_setopt and change itself. Get the write callback again after each chunk that has been written. reported-by: Joshua Rogers & The Super Intelligence
bagder
approved these changes
Sep 24, 2026
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation is reviewed; only a non-blocking regression-test nit remains.
Review effort: Lite
Findings: None
What changed in this PR
Updates cw-out to recheck write callback configuration after each output chunk, allowing callbacks to modify themselves during execution.
Changes:
- Refreshes callback, userdata, and write limits between chunks.
- Stops processing if the callback is removed.
| File | Summary |
|---|---|
lib/cw-out.c |
Rechecks write callback state during buffered output processing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A write function is allowed to invoked curl_easy_setopt and change itself. Get the write callback again after each chunk that has been written.
reported-by: Joshua Rogers & His Minions