Skip to content

cf-ngtcp2-cmn: fix possible -Wdeclaration-after-statement - #23094

Closed
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:quic-mixed-decl
Closed

vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:quic-mixed-decl

Conversation

@vszakats

@vszakats vszakats commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

E.g. (seen with LibreSSL build combined with ngtcp2 1.15.0):

lib/vquic/cf-ngtcp2-cmn.c:287:9: warning: mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement]
  287 |     int ossl_early_status = SSL_get_early_data_status(ctx->tls.ossl.ssl);
      |         ^

https://github.com/curl/curl/pull/23094/files?w=1

E.g.:
```
lib/vquic/cf-ngtcp2-cmn.c:287:9: warning: mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement]
  287 |     int ossl_early_status = SSL_get_early_data_status(ctx->tls.ossl.ssl);
      |         ^
```
@vszakats vszakats added build HTTP/3 h3 or quic related labels Sep 25, 2026
@vszakats

vszakats commented Sep 25, 2026 •

Copy link
Copy Markdown
Member Author

(AppVeyor CI took 16+ minutes to finish, partly because it takes many minutes to start up a runner machine. Maybe time to drop some jobs?)

@vszakats vszakats closed this in a2a0e4e Sep 25, 2026
@vszakats
vszakats deleted the quic-mixed-decl branch September 25, 2026 10:14
vszakats added a commit that referenced this pull request Sep 25, 2026
To improve CI performance. On the assumption that no-SSL builds have
limited usefulness nowadays. VS2026 and VS2022 remains tested in other
jobs.

Saving 1m15s to 1m45s twice.

Ref: #23094 (comment)

Closes #23095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build HTTP/3 h3 or quic related

Development

Successfully merging this pull request may close these issues.

1 participant