Repository navigation
Conversation
Do not think that response headers were complete when the stream was reset after an 1xx response. reported-by: Joshua Rogers
bagder
approved these changes
Sep 25, 2026
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Add regression coverage for a stream reset after a 1xx response.
Review effort: Lite
Findings: None
What changed in this PR
Fixes HTTP/2 response-header state tracking when a stream is reset after an informational 1xx response.
Changes:
- Marks headers complete only for final responses.
- Preserves incomplete-header state for
1xxresponses.
| File | Summary |
|---|---|
lib/http2.c |
Corrects final-response state handling; regression coverage for reset-after-1xx is still needed. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
I knew it would suggest that... |
dkarpov1970
pushed a commit
to dkarpov1970/curl
that referenced
this pull request
Nov 18, 2026
Do not think that response headers were complete when the stream was reset after an 1xx response. Reported-by: Joshua Rogers Closes curl#23104 (cherry picked from commit 790a219)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not think that response headers were complete when the stream was reset after an 1xx response.
reported-by: Joshua Rogers