Skip to content

http2: fix reset after 1xx response - #23104

Closed
icing wants to merge 1 commit into
curl:masterfrom
icing:h2-interim-reset
Closed

icing wants to merge 1 commit into
curl:masterfrom
icing:h2-interim-reset

Conversation

@icing

@icing icing commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Do not think that response headers were complete when the stream was reset after an 1xx response.

reported-by: Joshua Rogers

Do not think that response headers were complete when
the stream was reset after an 1xx response.

reported-by: Joshua Rogers

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Add regression coverage for a stream reset after a 1xx response.

Review effort: Lite
Findings: None

What changed in this PR

Fixes HTTP/2 response-header state tracking when a stream is reset after an informational 1xx response.

Changes:

  • Marks headers complete only for final responses.
  • Preserves incomplete-header state for 1xx responses.
File Summary
lib/​http2.c Corrects final-response state handling; regression coverage for reset-after-1xx is still needed.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@icing

icing commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

I knew it would suggest that...

@bagder bagder closed this in 790a219 Sep 25, 2026
dkarpov1970 pushed a commit to dkarpov1970/curl that referenced this pull request Nov 18, 2026
Do not think that response headers were complete when the stream was
reset after an 1xx response.

Reported-by: Joshua Rogers
Closes curl#23104

(cherry picked from commit 790a219)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants