Repository navigation
Conversation
icing
force-pushed
the
ech-config-rework
branch
from
September 28, 2026 12:34
ddf2d15 to
ca3d12d
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The quiche ECH path passes the wrong object to the HTTPS-RR helper, and the QUIC fallback contains invalid C syntax.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Moves ECH settings into SSL connection configuration, prevents reuse across incompatible ECH settings, and adds nghttpx-based ECH tests.
Changes:
- Centralizes ECH and HTTPS-RR handling across TLS/QUIC backends.
- Adds ECH configuration cloning and connection matching.
- Adds OpenSSL/nghttpx ECH test infrastructure and coverage.
| File | Description |
|---|---|
tests/http/testenv/nghttpx.py |
Adds ECH-enabled TCP and QUIC server support. |
tests/http/testenv/env.py |
Detects ECH tools and generates configurations. |
tests/http/testenv/__init__.py |
Exports the TCP nghttpx server. |
tests/http/test_23_ech.py |
Tests ECH modes, configurations, and public names. |
tests/http/Makefile.am |
Distributes the new test. |
tests/http/conftest.py |
Adds the TCP nghttpx fixture. |
src/config2setopts.c |
Applies ECH options in dependency order. |
lib/vtls/wolfssl.h |
Removes the backend-specific HTTPS-RR helper. |
lib/vtls/wolfssl.c |
Uses connection-scoped ECH configuration. |
lib/vtls/vtls.h |
Declares shared ECH helpers. |
lib/vtls/vtls.c |
Implements shared ECH decisions. |
lib/vtls/vtls_config.h |
Adds ECH connection/easy fields. |
lib/vtls/vtls_config.c |
Clones, matches, and cleans ECH configuration. |
lib/vtls/rustls.c |
Migrates rustls to connection-scoped ECH settings. |
lib/vtls/openssl.h |
Removes the OpenSSL-specific HTTPS-RR helper. |
lib/vtls/openssl.c |
Migrates OpenSSL ECH handling and tracing. |
lib/vquic/vquic.c |
Uses the inserted QUIC filter for ECH resolution. |
lib/vquic/cf-quiche.h |
Extends the insertion interface. |
lib/vquic/cf-quiche.c |
Returns the inserted quiche filter. |
lib/vquic/cf-ngtcp2.h |
Extends the ngtcp2 insertion interface. |
lib/vquic/cf-ngtcp2.c |
Returns the inserted ngtcp2 filter. |
lib/vquic/cf-ngtcp2-cmn.c |
Uses the shared HTTPS-RR helper. |
lib/urldata.h |
Removes the former ECH setting field. |
lib/setopt.c |
Stores ECH mode in SSL easy configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Move the easy configuration for `tsl_ech` into `struct ssl_easy_config`. Add `ech`, `ech_config` and `ech_public` to `struct ssl_filter_config`. Use the ECH config values in connection matching, so that different settings for the same origin to not get mixed up. Add test_23 for checking ECH with nghttpx if - nghttpx supports ECH - the `openssl` command is from OpenSSL 4 or later Verifies all ECH modes good/bad configs and the public name with OpenSSL.
- env.py: set ECH public name to have prefix 'public.' - test_23: fix expectations
- fix quiche macro use to pass cf - restrict some tests to openssl (and not lookalikes) that need it - add test for config matching on different ECH inputs
icing
force-pushed
the
ech-config-rework
branch
from
October 5, 2026 07:55
afe42d4 to
704bec4
Compare
- duplicate definitions after rebase - f string - unused var
Member
|
@icing: merge now or post 8.23.0 ? |
Contributor
Author
|
I'd vote for now as ECH through HTTPS proxies does not work otherwise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Move the easy configuration for
tsl_echintostruct ssl_easy_config. Addech,ech_configandech_publictostruct ssl_filter_config.Use the ECH config values in connection matching, so that different settings for the same origin to not get mixed up.
Add test_23 for checking ECH with nghttpx if
opensslcommand is from OpenSSL 4 or laterVerifies all ECH modes good/bad configs and the public name with OpenSSL.