Repository navigation
Conversation
They are supposed to be plain `secure` and `httponly` (without any following equals sign) but with this change, variations with `secure=[value]` and `httponly=[value]` are accepted and the value to the right of the equals sign is ignored. Possibly supported by RFC 6265 section 5.2.5 and 5.2.6. curl used to accept this format in the past. Verified in test 31 and 414. Reported-by: Wonyoung Jung
bagder
force-pushed
the
bagder/cookie-secure
branch
from
October 5, 2026 11:20
7b3cd4d to
71795a1
Compare
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The parser change matches cookie attribute semantics and both affected behaviors are verified.
Review effort: Balanced
Findings: None
What changed in this PR
Updates cookie parsing to accept values on Secure and HttpOnly attributes while ignoring those values.
Changes:
- Handles both attributes regardless of an equals separator.
- Adds coverage for valued
SecureandHttpOnlyattributes.
| File | Description |
|---|---|
lib/cookie.c |
Recognizes valued security attributes. |
tests/data/test31 |
Tests valued HttpOnly. |
tests/data/test414 |
Tests valued Secure. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
The AM wolfSSL-all CI run now ends with:
... which seems unrelated to this PR! |
secure bit is set when loaded from file
just don't invoke parse_domain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are supposed to be plain
secureandhttponly(without any following equals sign) but with this change, variations withsecure=[value]andhttponly=[value]are accepted and the value to the right of the equals sign is ignored.Possibly supported by RFC 6265 section 5.2.5 and 5.2.6.
curl used to accept this format in the past.
Verified in test 31 and 414.
Reported-by: Wonyoung Jung