Repository navigation
multi: is_finished() fix - #23295
Closed
icing wants to merge 1 commit into
Closed
multi: is_finished() fix#23295icing wants to merge 1 commit into
icing wants to merge 1 commit into
Conversation
When the progress callback errors on a not comppleted transfer, the transfer state entered COMPLETED right away and not DONE. This led to cleanup actions on the transfer/connection to not run. Only go to MSTATE_DONE in this case. reported-by: anthropic
bagder
approved these changes
Oct 7, 2026
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The corrected transition preserves cleanup while retaining the callback error result.
Review effort: Balanced
Findings: None
What changed in this PR
Fixes multi-transfer cleanup when a progress callback aborts an incomplete transfer.
Changes:
- Routes aborted transfers through
MSTATE_DONEsomulti_done()runs. - Adds an assertion that completed transfers have detached their connection.
| File | Description |
|---|---|
lib/multi.c |
Corrects state transitions and verifies connection cleanup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dkarpov1970
pushed a commit
to dkarpov1970/curl
that referenced
this pull request
Nov 18, 2026
When the progress callback errors on a not comppleted transfer, the transfer state entered COMPLETED right away and not DONE. This led to cleanup actions on the transfer/connection to not run. Only go to MSTATE_DONE in this case. Reported-by: Anthropic Closes curl#23295 Backport notes: - Dropped the DEBUGASSERT in mstate_enter_completed(), which the release lacks. (cherry picked from commit 11d0b20)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the progress callback errors on a not comppleted transfer, the transfer state entered COMPLETED right away and not DONE. This led to cleanup actions on the transfer/connection to not run.
Only go to MSTATE_DONE in this case.
reported-by: anthropic