Repository navigation
Conversation
|
Perhaps this could be extended to adjacent Perhaps in a separate PR. Another thought: if uniq </dev/null >/dev/null 2>&1; then
LIBCURL_PC_LDFLAGS_PRIVATE=`echo $LIBCURL_PC_LDFLAGS_PRIVATE | tr ' ' '\012' | uniq | tr '\012' ' '`
fi |
|
I'm skeptical of this. Couldn't there be legit reasons to repeat the libraries, like in cases of circular dependency? |
|
Using |
No, not when they are adjacent. |
These duplicates don't seem intentional to me. They rather look like I had to add tricks to This PR as it is now only removes adjacent idendtical LDFLAGS ( |
And from `curl-config`. To reduce redundant items and to bring the lib lists closer to their CMake-generated counterparts. Effect to `libcurl.pc` in the FreeBSD 15.1 CI job: ```diff -Libs.private: -L/usr/local/lib -lnghttp2 -lidn2 -lldap -llber -lssh2 -lssh2 -lpsl -lssl -lcrypto -lssl -lcrypto -L/usr/local/lib -lgssapi_krb5 -lzstd -lbrotlidec -lbrotlidec -lbrotlicommon -lz -pthread +Libs.private: -L/usr/local/lib -lnghttp2 -lidn2 -lldap -llber -lssh2 -lpsl -lssl -lcrypto -lssl -lcrypto -L/usr/local/lib -lgssapi_krb5 -lzstd -lbrotlidec -lbrotlicommon -lz -pthread ``` Ref: #23348 (comment) Follow-up to 05da26e #23348 Closes #23447
And from
curl-config. To avoid repeatpccriticwarnings for the samepotential issue.
Use POSIX
uniq. It's its first use in curl's autotools code.Also drop
pccriticexception for FreeBSD 15.1, it now passes withscore 98, like the rest of BSD jobs. In this case the dupes were
originating from
$LDFLAGSPC.Ref: #23346 (comment)
Effect to
libcurl.pcin the FreeBSD 15.1 CI job:Follow-up to ce0fe71 #23346