Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uplib655: silence compiler warning #2335
Conversation
MarcelRaad
approved these changes
Feb 23, 2018
jay
added
the
build
label
Feb 23, 2018
This comment has been minimized.
This comment has been minimized.
|
I don't get a warning for this also and neither does the CI. How is it being compiled that you see a warning? |
This comment has been minimized.
This comment has been minimized.
|
It appears on Travis CI: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Yes, warnings in tests and examples are easy to miss as they're never treated as errors. |
This comment has been minimized.
This comment has been minimized.
|
I'm fixing that mistake in #2337! |
bagder
approved these changes
Feb 23, 2018
This comment has been minimized.
This comment has been minimized.
|
I assume you meant to say that it silences a warning in lib655.c ? |
This comment has been minimized.
This comment has been minimized.
|
Yes, that's what I meant. I'm open to suggestions for better phrasing! |
This comment has been minimized.
This comment has been minimized.
|
Nah, I think the phrasing is fine if it just mentions the right file! =) |
bagder
referenced this pull request
Feb 23, 2018
Closed
build: make sure CFLAGS (including -werror) be used for examples and … #2337
This comment has been minimized.
This comment has been minimized.
|
Wow, indeed, I messed up a copy-paste, thanks a bunch for the heads up! Correcting it right away. |
vszakats
changed the title
lib1525: silence compiler warning
lib655.c: silence compiler warning
Feb 23, 2018
vszakats
changed the title
lib655.c: silence compiler warning
lib655: silence compiler warning
Feb 23, 2018
vszakats
closed this
in
a1d78ff
Feb 23, 2018
vszakats
deleted the
vszakats:lib655
branch
Feb 23, 2018
lock
bot
locked as resolved and limited conversation to collaborators
May 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
vszakats commentedFeb 23, 2018
No description provided.