New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib655: silence compiler warning #2335

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@vszakats
Member

vszakats commented Feb 23, 2018

No description provided.

@jay jay added the build label Feb 23, 2018

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Feb 23, 2018

Member

I don't get a warning for this also and neither does the CI. How is it being compiled that you see a warning?

Member

jay commented Feb 23, 2018

I don't get a warning for this also and neither does the CI. How is it being compiled that you see a warning?

@vszakats

This comment has been minimized.

Show comment
Hide comment
@vszakats
Member

vszakats commented Feb 23, 2018

@vszakats

This comment has been minimized.

Show comment
Hide comment
@vszakats

vszakats Feb 23, 2018

Member

With this one I can't spot any connection with PR #2334 (which belongs to the above Travis CI log). The warning looks valid, a global var is defined without a declaration, even though the variable is used in this file only. It was committed recently in 2371364.

Member

vszakats commented Feb 23, 2018

With this one I can't spot any connection with PR #2334 (which belongs to the above Travis CI log). The warning looks valid, a global var is defined without a declaration, even though the variable is used in this file only. It was committed recently in 2371364.

@MarcelRaad

This comment has been minimized.

Show comment
Hide comment
@MarcelRaad

MarcelRaad Feb 23, 2018

Member

Yes, warnings in tests and examples are easy to miss as they're never treated as errors.

Member

MarcelRaad commented Feb 23, 2018

Yes, warnings in tests and examples are easy to miss as they're never treated as errors.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Feb 23, 2018

Member

I'm fixing that mistake in #2337!

Member

bagder commented Feb 23, 2018

I'm fixing that mistake in #2337!

@bagder

bagder approved these changes Feb 23, 2018

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Feb 23, 2018

Member

I assume you meant to say that it silences a warning in lib655.c ?

Member

bagder commented Feb 23, 2018

I assume you meant to say that it silences a warning in lib655.c ?

@vszakats

This comment has been minimized.

Show comment
Hide comment
@vszakats

vszakats Feb 23, 2018

Member

Yes, that's what I meant. I'm open to suggestions for better phrasing!

Member

vszakats commented Feb 23, 2018

Yes, that's what I meant. I'm open to suggestions for better phrasing!

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Feb 23, 2018

Member

Nah, I think the phrasing is fine if it just mentions the right file! =)

Member

bagder commented Feb 23, 2018

Nah, I think the phrasing is fine if it just mentions the right file! =)

@vszakats

This comment has been minimized.

Show comment
Hide comment
@vszakats

vszakats Feb 23, 2018

Member

Wow, indeed, I messed up a copy-paste, thanks a bunch for the heads up! Correcting it right away.

Member

vszakats commented Feb 23, 2018

Wow, indeed, I messed up a copy-paste, thanks a bunch for the heads up! Correcting it right away.

@vszakats vszakats changed the title from lib1525: silence compiler warning to lib655.c: silence compiler warning Feb 23, 2018

@vszakats vszakats changed the title from lib655.c: silence compiler warning to lib655: silence compiler warning Feb 23, 2018

@vszakats vszakats closed this in a1d78ff Feb 23, 2018

@vszakats vszakats deleted the vszakats:lib655 branch Feb 23, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.