Skip to content

/ curl

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib655: silence compiler warning #2335

Closed
wants to merge 1 commit into from
Closed

lib655: silence compiler warning #2335

wants to merge 1 commit into from

Conversation

@vszakats
Copy link
Member

vszakats commented Feb 23, 2018

No description provided.

@vszakats
lib1525: silence compiler warning
Loading status checks…
7f69ee0
@MarcelRaad
MarcelRaad approved these changes Feb 23, 2018
View changes
@jay jay added the build label Feb 23, 2018
@jay

This comment has been minimized.

Sign in to view
Copy link
Member

jay commented Feb 23, 2018

I don't get a warning for this also and neither does the CI. How is it being compiled that you see a warning?
@vszakats

This comment has been minimized.

Sign in to view
Copy link
Member Author

vszakats commented Feb 23, 2018

It appears on Travis CI:
https://travis-ci.org/curl/curl/jobs/345254442#L3044
@vszakats

This comment has been minimized.

Sign in to view
Copy link
Member Author

vszakats commented Feb 23, 2018 •
edited

With this one I can't spot any connection with PR #2334 (which belongs to the above Travis CI log). The warning looks valid, a global var is defined without a declaration, even though the variable is used in this file only. It was committed recently in 2371364.
@MarcelRaad

This comment has been minimized.

Sign in to view
Copy link
Member

MarcelRaad commented Feb 23, 2018

Yes, warnings in tests and examples are easy to miss as they're never treated as errors.
@bagder

This comment has been minimized.

Sign in to view
Copy link
Member

bagder commented Feb 23, 2018

I'm fixing that mistake in #2337!
@bagder
bagder approved these changes Feb 23, 2018
View changes
@bagder

This comment has been minimized.

Sign in to view
Copy link
Member

bagder commented Feb 23, 2018

I assume you meant to say that it silences a warning in lib655.c ?
@vszakats

This comment has been minimized.

Sign in to view
Copy link
Member Author

vszakats commented Feb 23, 2018

Yes, that's what I meant. I'm open to suggestions for better phrasing!
@bagder

This comment has been minimized.

Sign in to view
Copy link
Member

bagder commented Feb 23, 2018

Nah, I think the phrasing is fine if it just mentions the right file! =)
@bagder bagder mentioned this pull request Feb 23, 2018
Closed
@vszakats

This comment has been minimized.

Sign in to view
Copy link
Member Author

vszakats commented Feb 23, 2018

Wow, indeed, I messed up a copy-paste, thanks a bunch for the heads up! Correcting it right away.
@vszakats vszakats changed the title lib1525: silence compiler warning lib655.c: silence compiler warning Feb 23, 2018
@vszakats vszakats changed the title lib655.c: silence compiler warning lib655: silence compiler warning Feb 23, 2018
@vszakats vszakats closed this in a1d78ff Feb 23, 2018
@vszakats vszakats deleted the vszakats:lib655 branch Feb 23, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder

@MarcelRaad MarcelRaad

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
4 participants
@vszakats @jay @MarcelRaad @bagder
You can’t perform that action at this time.