build: make sure CFLAGS (including -werror) be used for examples and … #2337

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@bagder
Owner

bagder commented Feb 23, 2018

…tests

... so that the CI and more detects compiler warnings/errors properly!

@bagder

This comment has been minimized.

Show comment Hide comment
@bagder

bagder Feb 23, 2018

Owner

The #2335 problem is clearly visible now at least!

Owner

bagder commented Feb 23, 2018

The #2335 problem is clearly visible now at least!

@bagder bagder added the build label Feb 23, 2018

build: make sure CFLAGS (including -werror) be used for examples and …
…tests

... so that the CI and more detects compiler warnings/errors properly!
@MarcelRaad

This comment has been minimized.

Show comment Hide comment
@MarcelRaad

MarcelRaad Feb 24, 2018

Member

I thought that was by design. I like this change, just note that it will need some fixup on MinGW. If I remember correctly, there's one warning in the examples because WinSock has non-standard signatures for send and recv and one warning in the tests about conversions between 32-bit long and 64-bit pointers. I'll try to have a look this afternoon.

Member

MarcelRaad commented Feb 24, 2018

I thought that was by design. I like this change, just note that it will need some fixup on MinGW. If I remember correctly, there's one warning in the examples because WinSock has non-standard signatures for send and recv and one warning in the tests about conversions between 32-bit long and 64-bit pointers. I'll try to have a look this afternoon.

@bagder

This comment has been minimized.

Show comment Hide comment
@bagder

bagder Feb 24, 2018

Owner

it will need some fixup on MinGW

I'm sure that's not the only fixup we need! =) But I figure I should start with making sure the CI builds are all happy and then we can proceed just as usual and fix the problems when we fall over them...

Owner

bagder commented Feb 24, 2018

it will need some fixup on MinGW

I'm sure that's not the only fixup we need! =) But I figure I should start with making sure the CI builds are all happy and then we can proceed just as usual and fix the problems when we fall over them...

@bagder bagder closed this in 8b0b1a3 Mar 4, 2018

@bagder bagder deleted the bagder/let-werror-propagate-to-tests-and-examples branch Mar 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment