Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused cleanup-order change is consistent with connection lifecycle requirements and has no identified correctness issues.
0 open findings
What changed in this PR
Adjusts transfer teardown in multi_done() to release resources in a safer order.
Changes:
- Completes request cleanup before notifying connection filters.
- Schedules pending transfers after returning the connection to the pool.
| File | Description |
|---|---|
lib/multi.c |
Reorders request, filter, connection-pool, and pending-transfer cleanup. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jeroen
added a commit
to autobrew/libcurl
that referenced
this pull request
Oct 14, 2026
Backport of upstream commit 8b0744a (curl#23370). Inform connection filters that the transfer is done only after Curl_req_done(), right before the connection is detached, so they give up references to `data` last. Process pending handles only after the connection has been returned to the pool. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jeroen
added a commit
to autobrew/libcurl
that referenced
this pull request
Oct 14, 2026
Backport of upstream commit 8b0744a ("multi: adjust the cleanup order in multi_done", curl#23370). Inform connection filters that the transfer is done only after Curl_req_done(), right before the connection is detached, so they give up references to `data` last. Process pending handles only after the connection has been returned to the pool. https://curl.se/docs/CVE-2026-92392.html Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dkarpov1970
pushed a commit
to dkarpov1970/curl
that referenced
this pull request
Nov 18, 2026
Closes curl#23370 Backport notes: - CVE-2026-92392 (HTTP/2 upload use-after-free): the fix is kept whole. Curl_conn_ev_data_done() now runs after Curl_req_done(), and pending handles are rescheduled after the connection is handled. - lib/multi.c: the release detaches the connection inside multi_done_locked() via Curl_cpool_do_locked(), so the reordering is applied around that call. - Not taken: upstream's "if(conn)" and "if(data->multi)" guards and the moved mdctx declaration. (cherry picked from commit 8b0744a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.