Repository navigation
[DONE] tool: preserve the default protocol for schemeless uploads - #23402
Closed
cla7aye15I4nd wants to merge 2 commits into
Closed
cla7aye15I4nd wants to merge 2 commits into
cla7aye15I4nd wants to merge 2 commits into
Conversation
bagder
approved these changes
Oct 15, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appending a local filename to a schemeless upload URL currently serializes the guessed scheme. For example,
curl --proto-default https -T secret.txt example.com/uploads/can acquire an explicithttp://URL during filename handling, preventing the requested HTTPS default from taking effect.Preserve the absence of an explicitly supplied scheme when serializing the updated URL by using
CURLU_NO_GUESS_SCHEME. Subsequent protocol selection can then apply--proto-default, or perform normal guessing when no default was specified. Explicit schemes remain unchanged. This does not introduce protocol fallback.Add regression test 3980: a schemeless
ftp.testupload uses--proto-default httpand a local HTTP proxy. The test checks the HTTP PUT request, demonstrating that the guessed FTP scheme does not override the selected HTTP default. This regression does not use HTTPS.Validation on macOS ARM64, debug/static OpenSSL 3.6.3:
AI assistance was used to investigate, implement, and test this change.