Repository navigation
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
bagder
reviewed
Oct 23, 2026
| my $tags = 'testcase|' . | ||
| 'info|client|reply|verify|' . | ||
| 'command|data|datacheck|disable|errorcode|features|keywords|killserver|limits|mdtm|name|notexists|postcheck|precheck|' . | ||
| 'protocol|proxy|server|servercmd|setenv|size|socks|stderr|stdin|stdout|strip|stripfile|strippart|tool|upload|valgrind'; |
Member
There was a problem hiding this comment.
Does it really need a list of known tags? Can't it detect any used tag and just warn if the same tag appears twice?
Member
Author
There was a problem hiding this comment.
Some tags can occure twice, and some of those can have a suffix,
so what would be possible is blocklisting all those, but that could be
more cumbersome I think.
Another way is to limit this list to the few that was seen being duplicates
in the past, and/or often used. That would be a shorter list.
Member
Author
There was a problem hiding this comment.
The blocklist method could work, I'm looking at it.
Member
Author
There was a problem hiding this comment.
It did work, and simplified/improvied things. It's now also checking
for those exceptions not to occure more than twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test results with #23571 reverted:
Ref: https://github.com/curl/curl/actions/runs/39865646942/job/120127058099?pr=23573#step:44:32
Also:
>.Follow-up to 631ed30 tool_cb_hdr: do not truncate existing file on filename-less C-D header #23501
Follow-up to 95f8e3a #23571
Follow-up to ffca9f6 #23562