Skip to content

scripts: don't insist on all executable bits on scripts - #23656

Closed
dfandrich wants to merge 1 commit into
masterfrom
dfandrich/exebits
Closed

dfandrich wants to merge 1 commit into
masterfrom
dfandrich/exebits

Conversation

@dfandrich

Copy link
Copy Markdown
Contributor

The scripts only need to be executable by the user; group and other are
not necessary. This avoids warnings on systems with a restrictive umask.

Closes #23656

The scripts only need to be executable by the user; group and other are
not necessary. This avoids warnings on systems with a restrictive umask.

Closes #23656
@testclutch

Copy link
Copy Markdown

Analysis of PR #23656 at e2d68b67:

Test ../../tests/http/test_03_goaway.py::TestGoAway::test_03_01_h2_goaway failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them).

Generated by Testclutch

Comment thread scripts/spacecheck.pl
my $mode = (stat($filename))[2];
if(($mode & 0111) != 0111) {
if(($mode & 0100) != 0100) {
push @err, sprintf('executable file missing executable bits: %o', $mode);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
push @err, sprintf('executable file missing executable bits: %o', $mode);
push @err, sprintf('executable file missing executable bit: %o', $mode);

let's make it singular if just one bit?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

@dfandrich dfandrich closed this in b61aa78 Oct 29, 2026
@dfandrich
dfandrich deleted the dfandrich/exebits branch October 29, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants