Repository navigation
Conversation
The scripts only need to be executable by the user; group and other are not necessary. This avoids warnings on systems with a restrictive umask. Closes #23656
|
Analysis of PR #23656 at e2d68b67: Test ../../tests/http/test_03_goaway.py::TestGoAway::test_03_01_h2_goaway failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Generated by Testclutch |
vszakats
reviewed
Oct 28, 2026
| my $mode = (stat($filename))[2]; | ||
| if(($mode & 0111) != 0111) { | ||
| if(($mode & 0100) != 0100) { | ||
| push @err, sprintf('executable file missing executable bits: %o', $mode); |
Member
There was a problem hiding this comment.
Suggested change
| push @err, sprintf('executable file missing executable bits: %o', $mode); | |
| push @err, sprintf('executable file missing executable bit: %o', $mode); |
let's make it singular if just one bit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scripts only need to be executable by the user; group and other are
not necessary. This avoids warnings on systems with a restrictive umask.
Closes #23656