darwinssl: fix iOS build#2397
Merged
bagder merged 1 commit intocurl:masterfrom Mar 18, 2018
chris-araman:issue-2396
Merged
Conversation
nickzman
approved these changes
Mar 18, 2018
Member
nickzman
left a comment
nickzman
left a comment
There was a problem hiding this comment.
Thanks! Guess what I forgot to check last time?
Contributor
Author
|
Who needs build automation when you have such a huge community of users? ;) |
Member
|
We CI all PRs and commits to the best of our abilities! At the same time, curl is built and used on a ridiculous amount of operating systems and 3rd party library combinations so we cannot ever expect to test them all before shipped. |
Contributor
Author
|
I understand. It’s a huge matrix. Thanks for getting the fix in quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion in #2396.