darwinssl: fix iOS build #2397

Merged
merged 1 commit into from Mar 18, 2018

Conversation

Projects
None yet
3 participants
@chris-araman
Contributor

chris-araman commented Mar 17, 2018

Discussion in #2396.

@bagder bagder requested a review from nickzman Mar 17, 2018

@bagder bagder added the SSL/TLS label Mar 17, 2018

@nickzman

Thanks! Guess what I forgot to check last time?

@chris-araman

This comment has been minimized.

Show comment Hide comment
@chris-araman

chris-araman Mar 18, 2018

Contributor

Who needs build automation when you have such a huge community of users? ;)

Contributor

chris-araman commented Mar 18, 2018

Who needs build automation when you have such a huge community of users? ;)

@bagder

This comment has been minimized.

Show comment Hide comment
@bagder

bagder Mar 18, 2018

Member

We CI all PRs and commits to the best of our abilities! At the same time, curl is built and used on a ridiculous amount of operating systems and 3rd party library combinations so we cannot ever expect to test them all before shipped.

Member

bagder commented Mar 18, 2018

We CI all PRs and commits to the best of our abilities! At the same time, curl is built and used on a ridiculous amount of operating systems and 3rd party library combinations so we cannot ever expect to test them all before shipped.

@bagder bagder merged commit b7b2809 into curl:master Mar 18, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.06%) to 75.017%
Details
@chris-araman

This comment has been minimized.

Show comment Hide comment
@chris-araman

chris-araman Mar 18, 2018

Contributor

I understand. It’s a huge matrix. Thanks for getting the fix in quickly.

Contributor

chris-araman commented Mar 18, 2018

I understand. It’s a huge matrix. Thanks for getting the fix in quickly.

@chris-araman chris-araman deleted the chris-araman:issue-2396 branch Mar 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment