Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper fix for NULL return from ldap_get_attribute_ber() #2399

Closed
wants to merge 1 commit into from

Conversation

hyc
Copy link
Contributor

@hyc hyc commented Mar 18, 2018

Attributes without values are valid results, don't stop processing.

@bagder bagder added the LDAP label Mar 19, 2018
data->req.bytecount += bv.bv_len + 3;
continue;
}

Copy link
Member

@bagder bagder Mar 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but this looks like an identical copy to a piece of code just a little further down. Shouldn't this then be moved into a separate function that get called from both places?

Copy link
Contributor Author

@hyc hyc Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar, but not identical since it only has an attribute name and no value to output. Didn't seem worthy of its own function but that's up to you.

Copy link
Member

@bagder bagder Mar 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, it might not be worth it...

@bagder
Copy link
Member

@bagder bagder commented Mar 23, 2018

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants