New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper fix for NULL return from ldap_get_attribute_ber() #2399

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@hyc
Contributor

hyc commented Mar 18, 2018

Attributes without values are valid results, don't stop processing.

@bagder bagder added the LDAP label Mar 19, 2018

data->req.bytecount += bv.bv_len + 3;
continue;
}

This comment has been minimized.

@bagder

bagder Mar 22, 2018

Member

Thanks, but this looks like an identical copy to a piece of code just a little further down. Shouldn't this then be moved into a separate function that get called from both places?

@bagder

bagder Mar 22, 2018

Member

Thanks, but this looks like an identical copy to a piece of code just a little further down. Shouldn't this then be moved into a separate function that get called from both places?

This comment has been minimized.

@hyc

hyc Mar 23, 2018

Contributor

Similar, but not identical since it only has an attribute name and no value to output. Didn't seem worthy of its own function but that's up to you.

@hyc

hyc Mar 23, 2018

Contributor

Similar, but not identical since it only has an attribute name and no value to output. Didn't seem worthy of its own function but that's up to you.

This comment has been minimized.

@bagder

bagder Mar 23, 2018

Member

You're right, it might not be worth it...

@bagder

bagder Mar 23, 2018

Member

You're right, it might not be worth it...

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Mar 23, 2018

Member

Thanks!

Member

bagder commented Mar 23, 2018

Thanks!

@bagder bagder closed this in b6e484d Mar 23, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jun 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.