Revert "openssl: Don't add verify locations when verifypeer==0"#2451
Closed
malhotrag wants to merge 1 commit intocurl:masterfrom
Closed
Revert "openssl: Don't add verify locations when verifypeer==0"#2451malhotrag wants to merge 1 commit intocurl:masterfrom
malhotrag wants to merge 1 commit intocurl:masterfrom
Conversation
This reverts commit dc85437. libcurl (with the OpenSSL backend) performs server certificate verification even if verifypeer == 0 and the verification result is available using CURLINFO_SSL_VERIFYRESULT. The commit that is being reverted caused the CURLINFO_SSL_VERIFYRESULT to not have useful information for the verifypeer == 0 use case (it would always have X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT_LOCALLY).
Contributor
Author
|
See comment on #2290 for more details |
Member
|
In the mean time, it seems the macos libressl build uses libressl 2.7.2 that causes a build error if this gets reverted. We should probably try to merge #2447 first then... |
Contributor
Author
|
Sorry, I'm a little confused by the comment. Are you saying the revert causes the build failure? As I understand it, the build failure is an existing issue that #2447 is attempting to fix. I also noticed a per-existing fuzzer failure. https://travis-ci.org/curl/curl/jobs/361624340 |
Member
|
The fuzz fail was fixed already in 82dfdac |
Member
|
Thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit dc85437.
libcurl (with the OpenSSL backend) performs server certificate verification
even if verifypeer == 0 and the verification result is available using
CURLINFO_SSL_VERIFYRESULT. The commit that is being reverted caused the
CURLINFO_SSL_VERIFYRESULT to not have useful information for the
verifypeer == 0 use case (it would always have
X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT_LOCALLY).