Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Revert "openssl: Don't add verify locations when verifypeer==0" #2451
This reverts commit dc85437.
libcurl (with the OpenSSL backend) performs server certificate verification
This reverts commit dc85437. libcurl (with the OpenSSL backend) performs server certificate verification even if verifypeer == 0 and the verification result is available using CURLINFO_SSL_VERIFYRESULT. The commit that is being reverted caused the CURLINFO_SSL_VERIFYRESULT to not have useful information for the verifypeer == 0 use case (it would always have X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT_LOCALLY).
Sorry, I'm a little confused by the comment. Are you saying the revert causes the build failure? As I understand it, the build failure is an existing issue that #2447 is attempting to fix.
I also noticed a per-existing fuzzer failure. https://travis-ci.org/curl/curl/jobs/361624340