New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix curl compilation with mbedTLS 2.7.0 and above (compiled with MBED… #2453

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@wyattoday
Contributor

wyattoday commented Apr 3, 2018

…TLS_DEPRECATED_REMOVED), and add error code handling for failed sha256 computation.

Fixes issue #2442

Fix curl compilation with mbedTLS 2.7.0 and above (compiled with MBED…
…TLS_DEPRECATED_REMOVED), and add error code handling for failed sha256 computation.

@bagder bagder added the SSL/TLS label Apr 5, 2018

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Apr 5, 2018

Member

Remember make checksrc to verify the code style somewhat:

./vtls/mbedtls.c:1036:5: warning: if with space (SPACEBEFOREPAREN)
   if (mbedtls_sha256_ret(input, inputlen, sha256sum, 0) != 0)
     ^
checksrc: 0 errors and 1 warnings
checksrc: 0 errors and 5 warnings suppressed
Member

bagder commented Apr 5, 2018

Remember make checksrc to verify the code style somewhat:

./vtls/mbedtls.c:1036:5: warning: if with space (SPACEBEFOREPAREN)
   if (mbedtls_sha256_ret(input, inputlen, sha256sum, 0) != 0)
     ^
checksrc: 0 errors and 1 warnings
checksrc: 0 errors and 5 warnings suppressed
@wyattoday

This comment has been minimized.

Show comment
Hide comment
@wyattoday

wyattoday Apr 5, 2018

Contributor

OK, just fixed the code style, ran the command again and came up all clean.

Contributor

wyattoday commented Apr 5, 2018

OK, just fixed the code style, ran the command again and came up all clean.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Apr 6, 2018

Member

Thanks!

Member

bagder commented Apr 6, 2018

Thanks!

@bagder bagder closed this in 336b6a3 Apr 6, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.