Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Winbuild: Updated BUILD.WINDOWS.txt to reflect more recent data #2472
Due to the check in Makefile.vc and MakefileBuild.vc, no make call can be invoked unless a build-type was specified. However, a clean target only existed when a build type was specified. As a result, the clean target was unreachable. Made clean target unconditional.
In modern Windows versions and/or more recent Visual Studio compilers, no setenv command exists. The way to open a CMD prompt with right settings is either done by vcvarsall.bat or VsDevCmd.bat. Also updated URLs to more recent SDK versions. The SDK is no longer called "platform SDK" but "Windows SDK" (by Microsoft).
The trouble here is that SetEnv as a tool comes and goes with the tide. For instance it is not available to me with a Visual Studio 2017 prompt for instance (as in what you get when I have said
My suggestion would be to not try to double guess the MS devs. One has to assume that the person reading this understands the tools so why not say
"Establish the VC build environment you need in the canonical way for the tool version you are using. Note that this has changed over time"
 http://www.hacker-dictionary.com/terms/canonical : So maybe a bit too nerdy for mainline documentation...
In Visual Studio you have vcvarsxxx.bat but also VsDevCmd.bat. I did not yet create a pull request, but I made some minor modifications to make BUILD_WINDOWS.txt slightly more up-to-date. See: master...kdekker:winbuild-doc. If you find these changes useful, I will create a PR (assuming you can access the previous URL)
This reverts commit 29ce9f4.
I reverted all on master branch of my own clone + forced (based on the comments of Marcel Raad) a sync with the remote repository. I don't know how to find your template. I'm almost struggling for 3 days how to create a PR. I understand that you have not that much time to explain, but just 'check our template' causes me to spend very much time, on just a simple documentation change. It requires really much courage (and time) to contribute to curl... I'm a little bit disappointed how much.
It would be great if you can provide an URL to the mentioned template.
To me, it seems this time you speak of is mostly you not knowing the primary tool we use: git. I don't know what we can do to make that ride easier... Also, making PRs on github is widely documented on github and elsewhere and also a procedure that is shared by millions of projects so lots of users already know how, plus once you've learned you'll be able to use this knowledge in many other projects.
The preferred commit message style is described in the regular contribute page. See the "Write good commit messages" subtitle.
You are right. Unfortunately, the MS website is doing this 'automagically'.
If this change was already committed on the master branch of the cURL repository, I will create a new PR and fix this URL. If this change was not yet committed, I will create a new branch in my own fork, and also create a new PR. If I understood Daniel's comments, this change is as #73070e8 on the master?
But as I made already some other mistakes, I really like to get a confirmation.