Winbuild: Updated BUILD.WINDOWS.txt to reflect more recent data #2472

Closed
wants to merge 12 commits into
from

Conversation

Projects
None yet
4 participants
@kdekker
Contributor

kdekker commented Apr 9, 2018

  1. Use URLs that point to newer versions of SDKs/documentation
  2. Updated text to reflect more recent Visual Studio versions (2015 and 2017)

kdekker added some commits Apr 4, 2018

winbuild: clean target cannot be called
Due to the check in Makefile.vc and MakefileBuild.vc, no make call can be invoked unless a build-type was specified. However, a clean target only existed when a build type was specified. As a result, the clean target was unreachable. Made clean target unconditional.
setenv command does not exist anymore
In modern Windows versions and/or more recent Visual Studio compilers, no setenv command exists. The way to open a CMD prompt with right settings is either done by vcvarsall.bat or VsDevCmd.bat.

Also updated URLs to more recent SDK versions. The SDK is no longer called "platform SDK" but "Windows SDK" (by Microsoft).
@rodwiddowson

This comment has been minimized.

Show comment Hide comment
@rodwiddowson

rodwiddowson Apr 5, 2018

Contributor

The trouble here is that SetEnv as a tool comes and goes with the tide. For instance it is not available to me with a Visual Studio 2017 prompt for instance (as in what you get when I have said

"d:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\vc\Auxiliary\Build\vcvars32.bat"

My suggestion would be to not try to double guess the MS devs. One has to assume that the person reading this understands the tools so why not say

"Establish the VC build environment you need in the canonical[1] way for the tool version you are using. Note that this has changed over time"

[1] http://www.hacker-dictionary.com/terms/canonical : So maybe a bit too nerdy for mainline documentation...

Contributor

rodwiddowson commented on 985c140 Apr 5, 2018

The trouble here is that SetEnv as a tool comes and goes with the tide. For instance it is not available to me with a Visual Studio 2017 prompt for instance (as in what you get when I have said

"d:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\vc\Auxiliary\Build\vcvars32.bat"

My suggestion would be to not try to double guess the MS devs. One has to assume that the person reading this understands the tools so why not say

"Establish the VC build environment you need in the canonical[1] way for the tool version you are using. Note that this has changed over time"

[1] http://www.hacker-dictionary.com/terms/canonical : So maybe a bit too nerdy for mainline documentation...

This comment has been minimized.

Show comment Hide comment
@kdekker

kdekker Apr 5, 2018

Contributor

In Visual Studio you have vcvarsxxx.bat but also VsDevCmd.bat. I did not yet create a pull request, but I made some minor modifications to make BUILD_WINDOWS.txt slightly more up-to-date. See: master...kdekker:winbuild-doc. If you find these changes useful, I will create a PR (assuming you can access the previous URL)

Contributor

kdekker replied Apr 5, 2018

In Visual Studio you have vcvarsxxx.bat but also VsDevCmd.bat. I did not yet create a pull request, but I made some minor modifications to make BUILD_WINDOWS.txt slightly more up-to-date. See: master...kdekker:winbuild-doc. If you find these changes useful, I will create a PR (assuming you can access the previous URL)

kdekker added some commits Apr 9, 2018

Updated windows build documentation.
The documentation was quite outdated. The setenv command no longer exists and visual studio build prompts got changed. Used Visual Studio 2015/2017 as reference.

@kdekker kdekker referenced this pull request Apr 9, 2018

Closed

Winbuild doc #2459

@bagder

This comment has been minimized.

Show comment Hide comment
@bagder

bagder Apr 9, 2018

Member

This PR has 11 irrelevant commits and 1 that you want merged...

Member

bagder commented Apr 9, 2018

This PR has 11 irrelevant commits and 1 that you want merged...

@bagder bagder closed this in 73070e8 Apr 9, 2018

@bagder

This comment has been minimized.

Show comment Hide comment
@bagder

bagder Apr 9, 2018

Member

I cherry-picked the single patch and merged that now. Please also check our template for commit messages, as that makes it even easier for us to receive your changes.

Thanks!

Member

bagder commented Apr 9, 2018

I cherry-picked the single patch and merged that now. Please also check our template for commit messages, as that makes it even easier for us to receive your changes.

Thanks!

@kdekker

This comment has been minimized.

Show comment Hide comment
@kdekker

kdekker Apr 9, 2018

Contributor

I reverted all on master branch of my own clone + forced (based on the comments of Marcel Raad) a sync with the remote repository. I don't know how to find your template. I'm almost struggling for 3 days how to create a PR. I understand that you have not that much time to explain, but just 'check our template' causes me to spend very much time, on just a simple documentation change. It requires really much courage (and time) to contribute to curl... I'm a little bit disappointed how much.

It would be great if you can provide an URL to the mentioned template.

Contributor

kdekker commented Apr 9, 2018

I reverted all on master branch of my own clone + forced (based on the comments of Marcel Raad) a sync with the remote repository. I don't know how to find your template. I'm almost struggling for 3 days how to create a PR. I understand that you have not that much time to explain, but just 'check our template' causes me to spend very much time, on just a simple documentation change. It requires really much courage (and time) to contribute to curl... I'm a little bit disappointed how much.

It would be great if you can provide an URL to the mentioned template.

@bagder

This comment has been minimized.

Show comment Hide comment
@bagder

bagder Apr 9, 2018

Member

It requires really much courage (and time) to contribute to curl... I'm a little bit disappointed how much.

To me, it seems this time you speak of is mostly you not knowing the primary tool we use: git. I don't know what we can do to make that ride easier... Also, making PRs on github is widely documented on github and elsewhere and also a procedure that is shared by millions of projects so lots of users already know how, plus once you've learned you'll be able to use this knowledge in many other projects.

The preferred commit message style is described in the regular contribute page. See the "Write good commit messages" subtitle.

Member

bagder commented Apr 9, 2018

It requires really much courage (and time) to contribute to curl... I'm a little bit disappointed how much.

To me, it seems this time you speak of is mostly you not knowing the primary tool we use: git. I don't know what we can do to make that ride easier... Also, making PRs on github is widely documented on github and elsewhere and also a procedure that is shared by millions of projects so lots of users already know how, plus once you've learned you'll be able to use this knowledge in many other projects.

The preferred commit message style is described in the regular contribute page. See the "Write good commit messages" subtitle.

@@ -12,7 +12,7 @@ Building with Visual C++, prerequisites
The latest Platform SDK can be downloaded freely from:
- https://msdn.microsoft.com/en-us/windows/bb980924
+ https://developer.microsoft.com/nl-nl/windows/downloads/sdk-archive

This comment has been minimized.

Show comment Hide comment
@MarcelRaad

MarcelRaad Apr 9, 2018

Member

en-us would probably be understood by more people than nl-nl ;-)

@MarcelRaad

MarcelRaad Apr 9, 2018

Member

en-us would probably be understood by more people than nl-nl ;-)

@kdekker

This comment has been minimized.

Show comment Hide comment
@kdekker

kdekker Apr 9, 2018

Contributor

You are right. Unfortunately, the MS website is doing this 'automagically'.
But how to continue now? As advised, I dropped the original fork and created a new one.

If this change was already committed on the master branch of the cURL repository, I will create a new PR and fix this URL. If this change was not yet committed, I will create a new branch in my own fork, and also create a new PR. If I understood Daniel's comments, this change is as #73070e8 on the master?

But as I made already some other mistakes, I really like to get a confirmation.

Contributor

kdekker commented Apr 9, 2018

You are right. Unfortunately, the MS website is doing this 'automagically'.
But how to continue now? As advised, I dropped the original fork and created a new one.

If this change was already committed on the master branch of the cURL repository, I will create a new PR and fix this URL. If this change was not yet committed, I will create a new branch in my own fork, and also create a new PR. If I understood Daniel's comments, this change is as #73070e8 on the master?

But as I made already some other mistakes, I really like to get a confirmation.

@MarcelRaad

This comment has been minimized.

Show comment Hide comment
@MarcelRaad

MarcelRaad Apr 9, 2018

Member

Ah, you're right, this is already in master. You will get it by doing a git pull --ff-only on your master branch. After that, you can create a new branch from that. Thanks!

Member

MarcelRaad commented Apr 9, 2018

Ah, you're right, this is already in master. You will get it by doing a git pull --ff-only on your master branch. After that, you can create a new branch from that. Thanks!

kdekker added a commit to kdekker/curl that referenced this pull request Apr 9, 2018

Fixed URL
Follow up on curl#2472.
Now using en-us instead of nl-nl as language code in the URL.
@kdekker

This comment has been minimized.

Show comment Hide comment
@kdekker

kdekker Apr 9, 2018

Contributor

Fixed now by filing a new PR (see above).

Contributor

kdekker commented Apr 9, 2018

Fixed now by filing a new PR (see above).

MarcelRaad added a commit that referenced this pull request Apr 9, 2018

winbuild: fix URL
Follow up on #2472.
Now using en-us instead of nl-nl as language code in the URL.

Closes #2475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment