urldata: make service names unconditional #2479
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The ifdefs have become quite long. Also, the condition for the
definition of
CURLOPT_SERVICE_NAME
and for setting it fromCURLOPT_SERVICE_NAME
have diverged. We will soon also need the twooptions for NTLM, at least when using SSPI, for #1660.
Just make the definitions unconditional to make that easier.
(Alternatively, the conditions could be updated to reflect actual usage.)