/ curl Public
Refactor malloc+memset to use calloc #2497
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
When a zeroed out allocation is required, most callsites in the code use
malloc()followed by an explicit
memset(). This PR refactors the remaining ones to use
calloc()instead to make the code more consistent and to avoid the risk of subtle bugs when code is injected
memset()by accident. Spotted while reading code.
Also remove to calls to
calloc()d allocation which is already zeroed out.