New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFTP fix #2500

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants
@MonkeybreadSoftware
Contributor

MonkeybreadSoftware commented Apr 15, 2018

We got people complaining about getting error with closing SFTP file and files only be partially uploaded.

So we added error details to the info messages.
All SFTP failures should be reported back with LibSSH2 error code and if possible an error message.

@MonkeybreadSoftware

This comment has been minimized.

Show comment
Hide comment
@MonkeybreadSoftware

MonkeybreadSoftware Apr 15, 2018

Contributor

Builds here on MacOS and Linux.

Contributor

MonkeybreadSoftware commented Apr 15, 2018

Builds here on MacOS and Linux.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Apr 15, 2018

Member

@MonkeybreadSoftware: remember make checksrc!

Member

bagder commented Apr 15, 2018

@MonkeybreadSoftware: remember make checksrc!

@MonkeybreadSoftware

This comment has been minimized.

Show comment
Hide comment
@MonkeybreadSoftware

MonkeybreadSoftware Apr 16, 2018

Contributor

checksrc made. Removed all warnings.

Contributor

MonkeybreadSoftware commented Apr 16, 2018

checksrc made. Removed all warnings.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Apr 16, 2018

Member

Thanks!

Member

bagder commented Apr 16, 2018

Thanks!

@bagder bagder closed this in 78611c7 Apr 16, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 15, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.