New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: handle on_begin_headers() called more than once #2507

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@bagder
Member

bagder commented Apr 18, 2018

This triggered an assert if called more than once in debug mode (and a
memory leak if not debug build). With the right sequence of HTTP/2
headers incoming it can happen.

Detected by OSS-Fuzz

Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7764

http2: handle on_begin_headers() called more than once
This triggered an assert if called more than once in debug mode (and a
memory leak if not debug build). With the right sequence of HTTP/2
headers incoming it can happen.

Detected by OSS-Fuzz

Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=7764

@bagder bagder added the HTTP/2 label Apr 18, 2018

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Apr 19, 2018

Member

looks fine to me. lgtm-ci failed analysis i think is a fluke, no logs found

Member

jay commented Apr 19, 2018

looks fine to me. lgtm-ci failed analysis i think is a fluke, no logs found

@bagder bagder closed this in 6d3c9c8 Apr 19, 2018

@bagder bagder deleted the bagder/http2-trailer-init branch Apr 19, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.