-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make OpenSSL builds with VS2015 work again #2512
Conversation
The build error doesn't seems to be related my changes (or are they)? |
You've introduced a memory leak in test 300:
|
... and a style nit:
|
This is still leaking memory in several of the travis builds, see this: |
@bagder Test 1056 is failing, seems connect operation timed out.. |
Yeah 1056 is on the border of getting marked as flaky. I've restarted that build since that failure isn't related to your work. |
Thanks for your hard work on this! |
Can't submit the code change with original pull request #1267. Hence creating new one.