make OpenSSL builds with VS2015 work again#2512
Closed
sunnyap wants to merge 4 commits into
Closed
Conversation
Contributor
Author
|
The build error doesn't seems to be related my changes (or are they)? |
Member
|
You've introduced a memory leak in test 300: |
Member
|
... and a style nit: |
Member
|
This is still leaking memory in several of the travis builds, see this: |
Contributor
Author
|
@bagder Test 1056 is failing, seems connect operation timed out.. |
Member
|
Yeah 1056 is on the border of getting marked as flaky. I've restarted that build since that failure isn't related to your work. |
Member
|
Thanks for your hard work on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can't submit the code change with original pull request #1267. Hence creating new one.