Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schannel: disable client cert path feature if APIs not available #2522

Closed
wants to merge 1 commit into from

Conversation

@ArchangelSDY
Copy link
Contributor

@ArchangelSDY ArchangelSDY commented Apr 23, 2018

Original MinGW targets Windows 2000 by default, which lacks some APIs and definitions for this feature. Disable it if required APIs not available.

@mback2k Could you help review that if the __MINGW_H macro is sufficient for the judgement? I know little about MinGW.

@mback2k
Copy link
Member

@mback2k mback2k commented Apr 23, 2018

Please do not disable this feature for all MinGW builds. MinGW-w64 and Msys2 provide updated APIs which include the required definitions, see the other builds here: https://curlbuild.uxnr.de/waterfall (only 2 of them are failing.)

Please check for the required API instead. Another approach would be to add the required definitions if they are missing, like here: https://github.com/curl/curl/blob/master/lib/vtls/schannel.c#L99

…able

Original MinGW targets Windows 2000 by default, which lacks some APIs and
definitions for this feature. Disable it if these APIs are not available.
@ArchangelSDY ArchangelSDY force-pushed the ArchangelSDY:schannel-client-cert branch from 8c406a5 to fdeec2e Apr 23, 2018
@ArchangelSDY
Copy link
Contributor Author

@ArchangelSDY ArchangelSDY commented Apr 23, 2018

OK. Updated to check macro definitions.

@ArchangelSDY ArchangelSDY changed the title schannel: disable client cert path feature in MinGW schannel: disable client cert path feature if APIs not available Apr 23, 2018
@bagder
Copy link
Member

@bagder bagder commented Apr 24, 2018

@mback2k looking like a 👍 for you too?

@jay
Copy link
Member

@jay jay commented Apr 25, 2018

what about convert the hex to binary on our own

@ArchangelSDY
Copy link
Contributor Author

@ArchangelSDY ArchangelSDY commented Apr 25, 2018

Well, basically I don't think it's a good idea to re-invent a function in a crypto library. Since MinGW seems not to be actively maintained, MinGW-w64 should be a better choice.

@jay jay closed this in 1592ea9 May 16, 2018
@jay
Copy link
Member

@jay jay commented May 16, 2018

Thanks

@mback2k
Copy link
Member

@mback2k mback2k commented May 16, 2018

Sorry for my absence. Thanks a lot.

@bagder
Copy link
Member

@bagder bagder commented May 16, 2018

I had to polish the schannel code slightly with f0c466d, but it shouldn't cause any problems...

@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.