schannel: disable client cert path feature if APIs not available#2522
schannel: disable client cert path feature if APIs not available#2522ArchangelSDY wants to merge 1 commit intocurl:masterfrom
Conversation
|
Please do not disable this feature for all MinGW builds. MinGW-w64 and Msys2 provide updated APIs which include the required definitions, see the other builds here: https://curlbuild.uxnr.de/waterfall (only 2 of them are failing.) Please check for the required API instead. Another approach would be to add the required definitions if they are missing, like here: https://github.com/curl/curl/blob/master/lib/vtls/schannel.c#L99 |
…able Original MinGW targets Windows 2000 by default, which lacks some APIs and definitions for this feature. Disable it if these APIs are not available.
ArchangelSDY
force-pushed
the
schannel-client-cert
branch
from
8c406a5 to
fdeec2e
Compare
|
OK. Updated to check macro definitions. |
ArchangelSDY
changed the title
|
@mback2k looking like a 👍 for you too? |
|
what about convert the hex to binary on our own |
|
Well, basically I don't think it's a good idea to re-invent a function in a crypto library. Since MinGW seems not to be actively maintained, MinGW-w64 should be a better choice. |
|
Thanks |
|
Sorry for my absence. Thanks a lot. |
|
I had to polish the schannel code slightly with f0c466d, but it shouldn't cause any problems... |
4 participants
Original MinGW targets Windows 2000 by default, which lacks some APIs and definitions for this feature. Disable it if required APIs not available.
@mback2k Could you help review that if the
__MINGW_Hmacro is sufficient for the judgement? I know little about MinGW.