Fix ASSIGNWITHINCONDITION checksrc warnings in os400sys.c #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All occurrences of assignment within conditional expression in os400sys.c rewritten into two steps: first assignment and then the check on the success of the assignment. Also adjust related incorrect brace positions to match project indentation style. This was spurred by seeing "if((inp = input_token))", but while in there all warnings were fixed. There should be no functional change from these changes.
bagder
approved these changes
Apr 23, 2018
|
any other comments perhaps, @monnerat ? |
|
Thanks! |
|
Nothing special to say about it: most of the updated code is dated 2007 and checksrc has never been applied to it before. The only thing we can hope is it does not break the IBM C compiler since it it is not tested, although not adding any feature. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
All occurrences of assignment within conditional expression in
os400sys.crewritten into two steps: first assignment and then the check on the success of the assignment. Also adjust related incorrect brace positions to match project indentation style.This was spurred by seeing
if((inp = input_token)), but while in there all warnings were fixed.There should be no functional change from these changes, but as I don't have an OS/400 system it was done somewhat blind. Thus, this requires actual testing to go anywhere but it seemed a worthwhile exercise to reduce the number of checksrc warnings in the tree.