Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix ASSIGNWITHINCONDITION checksrc warnings in os400sys.c #2525
All occurrences of assignment within conditional expression in
This was spurred by seeing
There should be no functional change from these changes, but as I don't have an OS/400 system it was done somewhat blind. Thus, this requires actual testing to go anywhere but it seemed a worthwhile exercise to reduce the number of checksrc warnings in the tree.
All occurrences of assignment within conditional expression in os400sys.c rewritten into two steps: first assignment and then the check on the success of the assignment. Also adjust related incorrect brace positions to match project indentation style. This was spurred by seeing "if((inp = input_token))", but while in there all warnings were fixed. There should be no functional change from these changes.
Nothing special to say about it: most of the updated code is dated 2007 and checksrc has never been applied to it before. The only thing we can hope is it does not break the IBM C compiler since it it is not tested, although not adding any feature.