Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that we have cookies before writing jar #2529


Copy link

@danielgustafsson danielgustafsson commented Apr 24, 2018

The jar should only be written if there are any cookies, but there is no re-check on c->numcookies after the removal of expired cookies. Add another check after expiration to be able to avoid an empty file, should all cookies be expired.

The jar should be written iff there are cookies, so ensure that we
still have cookies after expiration to avoid creating an empty file.
bagder approved these changes Apr 24, 2018
Copy link

bagder commented Apr 24, 2018

(Pro-tip: you'll earn more bonus points if you also make the commit message follow our "template" style, documented here. 😉 )

Copy link
Member Author

danielgustafsson commented Apr 24, 2018

Copy link

bagder commented Apr 25, 2018


@bagder bagder closed this in 732d093 Apr 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants