Ensure that we have cookies before writing jar #2529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The jar should be written iff there are cookies, so ensure that we still have cookies after expiration to avoid creating an empty file.
bagder
approved these changes
Apr 24, 2018
|
(Pro-tip: you'll earn more bonus points if you also make the commit message follow our "template" style, documented here. 😉 ) |
|
On 24 Apr 2018, at 23:31, Daniel Stenberg ***@***.***> wrote:
(Pro-tip: you'll earn more bonus points if you also make the commit message follow our "template" style, documented here. 😉 )
Doh, had missed that. Will do from here on.
|
|
Thanks! |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jar should only be written if there are any cookies, but there is no re-check on
c->numcookiesafter the removal of expired cookies. Add another check after expiration to be able to avoid an empty file, should all cookies be expired.