New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that we have cookies before writing jar #2529

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@danielgustafsson
Member

danielgustafsson commented Apr 24, 2018

The jar should only be written if there are any cookies, but there is no re-check on c->numcookies after the removal of expired cookies. Add another check after expiration to be able to avoid an empty file, should all cookies be expired.

Ensure that we have cookies before writing jar
The jar should be written iff there are cookies, so ensure that we
still have cookies after expiration to avoid creating an empty file.
@bagder

bagder approved these changes Apr 24, 2018

@bagder

This comment has been minimized.

Member

bagder commented Apr 24, 2018

(Pro-tip: you'll earn more bonus points if you also make the commit message follow our "template" style, documented here. 😉 )

@danielgustafsson

This comment has been minimized.

Member

danielgustafsson commented Apr 24, 2018

@bagder

This comment has been minimized.

Member

bagder commented Apr 25, 2018

Thanks!

@bagder bagder closed this in 732d093 Apr 25, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.