Force indentation of lines after an else in checksrc

[danielgustafsson]

This extends the INDENTATION case to also handle else statements and require proper indentation on the following line. Included are also fixes for the offending cases found in the codebase.

[jay]

does it allow for this:

#ifdef MACRO
  if(foo) {
    bar();
  }
  else
#endif
  {
    qux();
  }

[jay]

does it allow for this:

#ifdef MACRO
  if(foo) {
    bar();
  }
  else
#endif
  {
    qux();
  }

[danielgustafsson]

On 25 Apr 2018, at 22:30, Jay Satiro ***@***.***> wrote: does it allow for this: #ifdef MACRO if(foo) { bar(); } else #endif { qux(); }

Yes, it allows for preprocessor lines in the same way as if/while/for.

[danielgustafsson]

On 25 Apr 2018, at 22:30, Jay Satiro ***@***.***> wrote: does it allow for this: #ifdef MACRO if(foo) { bar(); } else #endif { qux(); }

Yes, it allows for preprocessor lines in the same way as if/while/for.

[bagder]

This change seems to detect more (unfixed) problems! =)

./stub_gssapi.c:327:8: warning: not indented 2 steps, uses 3) (INDENTATION)
        return GSS_S_FAILURE;
        ^

[bagder]

This change seems to detect more (unfixed) problems! =)

./stub_gssapi.c:327:8: warning: not indented 2 steps, uses 3) (INDENTATION)
        return GSS_S_FAILURE;
        ^

[bagder]

BTW, the error message seems to use a single right parenthesis weirdly there.

[bagder]

BTW, the error message seems to use a single right parenthesis weirdly there.

[danielgustafsson]

Pushed a rebased and updated branch with the missing fix in stub_gssapi.c and a commit updating the error message (hadn't noticed the spelling but now I can't unsee it).

[danielgustafsson]

Pushed a rebased and updated branch with the missing fix in stub_gssapi.c and a commit updating the error message (hadn't noticed the spelling but now I can't unsee it).

[bagder]

Thanks!

[bagder]

Thanks!