curl: show headers in bold

[bagder]

The feature is only enabled if the output is believed to be a tty.

-J: There's some minor differences and improvements in -J handling, as
now J should work with -i and it actually creates a file first using the
initial name and then renames that to the one found in
Content-Disposition (if any).

-i: only shows headers for HTTP transfers now (as documented).
Previously it would also show for pieces of the transfer that were HTTP
(for example when doing FTP over a HTTP proxy).

-i: now shows trailers as well. Previously they were not shown at all.

--libcurl: the CURLOPT_HEADER is no longer set, as the header output is
now done in the header callback.

[bagder]

Sample look:

[jay]

The windows console doesn't treat ansi escape codes as special, and as far as I know bold isn't possible

You will probably need to do something like this
#ifdef WIN32
#define BOLD_ON
#else
#define BOLD_ON "\x1b[1m"
#endif
and same for bold off

[bagder]

The windows console doesn't treat ansi escape codes as special

The question is perhaps if there's a chance the curl executable might be used in a terminal/console on windows that supports them? If so, that might require us to toggle this feature on/off depending on the terminal type in use...

[BobVul]

The windows console doesn't treat ansi escape codes as special

Technically, it does support the bold escape sequence in the most recent versions. Except conhost renders it as the bright version of the current colour, not bold.

In a completely default cmd-in-conhost window, this means bold is bright white and normal (default) text is (dim) white, so you do still benefit from the colour difference. In a default powershell-in-conhost window, normal (default) text is already bright white and setting 'bold' makes no difference.

This would also depend on the curl executable setting the ENABLE_VIRTUAL_TERMINAL_PROCESSING flag (it's not passed along by built-in shells, i.e. cmd & powershell).

[bagder]

Rebased and now disabled on Windows.

[jindraj]

There's different behaviour for
curl --styled-output -D - url
and
curl --styled-output -I url
While -I shows headers in bold, -D - doesn't.
Is that expected behaviour?

[bagder]

It is expected since I only enabled it for -I and -i. But I believe it should be possible to add for "-D -" too...

[jindraj]

I never used -i, but it's almost the same as -D -.

curl -i example.com prints even HTML in bold. At least for me. I have curl 7.61.0 installed from brew on macOS.

[bagder]

See #2736 and #2738

[xvybihal]

From left to right: LilyTerm, Termit, Gnome Terminal, Terminator.

https://i.imgur.com/EFD1XJW.png

[bagder]

@xvybihal but how does the fix in #2738 work on those?