Put CURLDEBUG and DEBUGBUILD in lib/curl_config.h. #2548
I ripped them out like this (after I applied your comit) and I see no issues:
diff --git a/m4/curl-compilers.m4 b/m4/curl-compilers.m4 index 20bdbd706..c1ae6a559 100644 --- a/m4/curl-compilers.m4 +++ b/m4/curl-compilers.m4 @@ -3,11 +3,11 @@ # Project ___| | | | _ \| | # / __| | | | |_) | | # | (__| |_| | _ <| |___ # \___|\___/|_| \_\_____| # -# Copyright (C) 1998 - 2017, Daniel Stenberg, <email@example.com>, et al. +# Copyright (C) 1998 - 2018, Daniel Stenberg, <firstname.lastname@example.org>, et al. # # This software is licensed as described in the file COPYING, which # you should have received as part of this distribution. The terms # are also available at https://curl.haxx.se/docs/copyright.html. # @@ -1297,19 +1297,10 @@ AC_DEFUN([CURL_CHECK_CURLDEBUG], [ if test "$supports_curldebug" = "no"; then AC_MSG_WARN([cannot enable curl debug memory tracking.]) want_curldebug="no" fi fi - # - if test "$want_curldebug" = "yes"; then - CPPFLAGS="-DCURLDEBUG $CPPFLAGS" - squeeze CPPFLAGS - fi - if test "$want_debug" = "yes"; then - CPPFLAGS="-DDEBUGBUILD $CPPFLAGS" - squeeze CPPFLAGS - fi ]) dnl CURL_CHECK_COMPILER_HALT_ON_ERROR
They are removed from the compiler flags. This ensures that make dependency tracking will force a rebuild whenever configure --enable-debug or --enable-curldebug changes.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.