Skip to content

winbuild: In MakefileBuild.vc fix typo DISTDIR->DIRDIST#2603

Closed
richardthe3rd wants to merge 1 commit intocurl:masterfrom
richardthe3rd:richardthe3rd-winbuild-dirdist-typo
Closed

winbuild: In MakefileBuild.vc fix typo DISTDIR->DIRDIST#2603
richardthe3rd wants to merge 1 commit intocurl:masterfrom
richardthe3rd:richardthe3rd-winbuild-dirdist-typo

Conversation

@richardthe3rd
Copy link
Contributor

I assume this is a simple typo. This is the only place that uses $(DISTDIR) and $(DIRDIST) is used everywhere else in the file.

@bagder
Copy link
Member

bagder commented May 24, 2018

Did you intend to submit three commits and not only the last one?

@bagder bagder added build Windows Windows-specific labels May 24, 2018
Change requirement from $(DISTDIR) to $(DIRDIST)
@richardthe3rd richardthe3rd force-pushed the richardthe3rd-winbuild-dirdist-typo branch from 58b59be to 80686ba Compare May 24, 2018 20:36
@richardthe3rd
Copy link
Contributor Author

I didn't mean to. Cleaned it up.

@bagder
Copy link
Member

bagder commented May 27, 2018

Thanks!

@bagder bagder closed this in 75c51e0 May 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

build Windows Windows-specific

Development

Successfully merging this pull request may close these issues.

2 participants