New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winbuild: In MakefileBuild.vc fix typo DISTDIR->DIRDIST #2603

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@richardthe3rd
Contributor

richardthe3rd commented May 24, 2018

I assume this is a simple typo. This is the only place that uses $(DISTDIR) and $(DIRDIST) is used everywhere else in the file.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder May 24, 2018

Member

Did you intend to submit three commits and not only the last one?

Member

bagder commented May 24, 2018

Did you intend to submit three commits and not only the last one?

winbuild: In MakefileBuild.vc fix typo DISTDIR->DIRDIST
Change requirement from $(DISTDIR) to $(DIRDIST)
@richardthe3rd

This comment has been minimized.

Show comment
Hide comment
@richardthe3rd

richardthe3rd May 24, 2018

Contributor

I didn't mean to. Cleaned it up.

Contributor

richardthe3rd commented May 24, 2018

I didn't mean to. Cleaned it up.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder May 27, 2018

Member

Thanks!

Member

bagder commented May 27, 2018

Thanks!

@bagder bagder closed this in 75c51e0 May 27, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Aug 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.