New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schannel: Add failf calls for client certificate failures #2604

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@richardthe3rd
Contributor

richardthe3rd commented May 24, 2018

Add failf calls with information related to problems with locating and loading client certificates.

@bagder bagder added the SSL/TLS label May 24, 2018

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder May 25, 2018

Member

CI complaints:

./vtls/schannel.c:442:87: warning: Longer than 79 columns (LONGLINE)
         failf(data, "schannel: Failed to get certificate location for %s", cert_path);
./vtls/schannel.c:451:100: warning: Longer than 79 columns (LONGLINE)
         failf(data, "schannel: Failed to open cert store %s %s", cert_store_name, cert_store_path);
Member

bagder commented May 25, 2018

CI complaints:

./vtls/schannel.c:442:87: warning: Longer than 79 columns (LONGLINE)
         failf(data, "schannel: Failed to get certificate location for %s", cert_path);
./vtls/schannel.c:451:100: warning: Longer than 79 columns (LONGLINE)
         failf(data, "schannel: Failed to open cert store %s %s", cert_store_name, cert_store_path);
ralcock
@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder May 27, 2018

Member

thanks!

Member

bagder commented May 27, 2018

thanks!

@bagder bagder closed this in 45eefbd May 27, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Aug 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.