New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link with ssh2 built with a static mbedtls #2613

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@ffontaine
Contributor

ffontaine commented May 28, 2018

The ssh2 pkg-config file could contain the following lines when build
with a static version of mbedtls:
Libs: -L${libdir} -lssh2 /xxx/libmbedcrypto.a
Libs.private: /xxx/libmbedcrypto.a

This static mbedtls library must be used to correctly detect ssh2
support and this library must be copied in libcurl.pc otherwise
compilation of any application (such as upmpdcli) with libcurl will fail
when trying to found mbedtls functions included in libssh2.
So, replace pkg-config --libs-only-l by pkg-config --libs.

Fixes:

Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

Fix link with ssh2 built with a static mbedtls
The ssh2 pkg-config file could contain the following lines when build
with a static version of mbedtls:
   Libs: -L${libdir} -lssh2 /xxx/libmbedcrypto.a
   Libs.private: /xxx/libmbedcrypto.a

This static mbedtls library must be used to correctly detect ssh2
support and this library must be copied in libcurl.pc otherwise
compilation of any application (such as upmpdcli) with libcurl will fail
when trying to found mbedtls functions included in libssh2.
So, replace pkg-config --libs-only-l by pkg-config --libs.

Fixes:
 - http://autobuild.buildroot.net/results/43e24b22a77f616d6198c10435dcc23cc3b9088a

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

@bagder bagder added the build label May 28, 2018

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder May 28, 2018

Member

Thanks!

Member

bagder commented May 28, 2018

Thanks!

@bagder bagder closed this in 536e9f8 May 28, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Aug 26, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.