CURLOPT_RESOLVE and nearly expired DNS Cache entries: replace old entry

[ajorajev]

We use CURLOPT_RESOLVE to tell Curl to use specific addresses instead of doing real DNS lookup.

when cached address is already there (saved by Curl internally) and close to expire, then by the time next http request is made, it can get expired.

Partial fix would be to mark existing entry as set by CURLOPT_RESOLVE (by setting timestamp to zero). This will keep this entry permanently in the cache as intended.

However, currently, if the cache entry already exists, CURLOPT_RESOLVE just leaves it, thus
an old address remains (while calling code expects new address to be saved).

Let's say that cURL already looked up "example.org" recently and found its IP address to be 1.1.1.1.
As usual, it's stored in the relevant DNS cache. Then, later, we issue a new request that uses the same DNS cache, and that 1.1.1.1 entry is still in the cache.

Then, if we do:
curl_easy_setopt(handle, CURLOPT_RESOLVE, [ "example.org:80:2.2.2.2" ]); and then issue the new request, we want this current request to use 2.2.2.2 as its IP

So it is best if we always override existing entries.

[bagder]

Thanks, try make checksrc to make sure there's no style warnings. The CI found this nit:

./unit1609.c:128:54: warning: sizeof without parenthesis (SIZEOFNOPAREN)
     int addressnum = sizeof tests[i].address / sizeof *tests[i].address;
                                                      ^

[ajorajev]

thanks, just fixed now, will always run "make checkrsc" from now on.

[bagder]

I don't think this belongs here.

[ajorajev]

this is local file, which MacOS creates to store custom attributes of its containing folder (position of icons, etc.). when I create local GIT copy, this file is always coming up and I assume it happens to other developers (who use Mac).
but yes, having perused all content of .gitignore I can see that it contains wildcards to files related to Curl itself. I will remove this now and check is there way to configure GIT locally to ignore some files.

[ajorajev]

ok, I found solution - I can have my own gitignore using:

git config --global core.excludesfile ~/.gitignore

[jzakrzewski]

Maybe explicitly ignoring all dot-files + whitelisting those we need wouldn't be a bad idea?

[bagder]

I don't see a need for that. I think we should stick to ignoring files that are generated by a curl build. If you want to ignore more files, it is very easy to do what @ajorajev did and just set your own ignore files for those - I do that too.

[jzakrzewski]

I thought the same before I've spotted Vim, Eclipse, and backup files typical for Pluma/GEdit/etc there. But I won't argue on it.

[bagder]

Right, but I consider editor backup files to be sort of "generated by a curl build" or at least "created as a result of someone working on curl".

[bagder]

Thanks!

[ajorajev]

thank you too.