fnmatch: use the system one if available #2626

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
1 participant
@bagder
Member

bagder commented May 31, 2018

If configure detects fnmatch to be available, use that instead of our
custom one for pattern matching. For standard compliance, to reduce our
footprint and to use already well tested and well exercised code.

A POSIX fnmatch behaves slightly different than the internal function
for a few test patterns currently, and test 1307 is adjusted for this.
This is considered a bug.

fnmatch: use the system one if available
If configure detects fnmatch to be available, use that instead of our
custom one for pattern matching. For standard compliance, to reduce our
footprint and to use already well tested and well exercised code.

A POSIX fnmatch behaves slightly different than the internal function
for a few test patterns currently, and test 1307 is adjusted for this.
This is considered a bug.
@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder May 31, 2018

Member

Oh crap. It looks as if the macOS fnmatch function doesn't work exactly like the Linux version in test 1307, causing test failures due to mismatched return codes. How fun. I'll investigate closer tomorrow.

So much for POSIX compliance.

Member

bagder commented May 31, 2018

Oh crap. It looks as if the macOS fnmatch function doesn't work exactly like the Linux version in test 1307, causing test failures due to mismatched return codes. How fun. I'll investigate closer tomorrow.

So much for POSIX compliance.

@bagder bagder closed this in a115c6b Jun 1, 2018

@bagder bagder deleted the bagder/system-fnmatch branch Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment