New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple fixes for issues found by Cppcheck #2631

Closed
wants to merge 15 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Nekto89
Contributor

Nekto89 commented Jun 3, 2018

Cppcheck 1.83
Mostly reducing scope of variables.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Jun 3, 2018

Member

Remember 'make checksrc':

./lib506.c:134:2: warning: Trailing whitespace (TRAILINGSPACE)
   
  ^
./lib512.c:39:2: warning: Trailing whitespace (TRAILINGSPACE)
   
  ^
./lib556.c:74:4: warning: Trailing whitespace (TRAILINGSPACE)
     
    ^
./lib586.c:102:2: warning: Trailing whitespace (TRAILINGSPACE)
   
  ^
Member

bagder commented Jun 3, 2018

Remember 'make checksrc':

./lib506.c:134:2: warning: Trailing whitespace (TRAILINGSPACE)
   
  ^
./lib512.c:39:2: warning: Trailing whitespace (TRAILINGSPACE)
   
  ^
./lib556.c:74:4: warning: Trailing whitespace (TRAILINGSPACE)
     
    ^
./lib586.c:102:2: warning: Trailing whitespace (TRAILINGSPACE)
   
  ^
@Nekto89

This comment has been minimized.

Show comment
Hide comment
@Nekto89

Nekto89 Jun 3, 2018

Contributor

I should have thought of something like this
git ls-files -z -- '.c' '.h' | xargs -0 sed -i 's/ +$//'
instead of manually fixing files from error logs

Contributor

Nekto89 commented Jun 3, 2018

I should have thought of something like this
git ls-files -z -- '.c' '.h' | xargs -0 sed -i 's/ +$//'
instead of manually fixing files from error logs

Show outdated Hide outdated lib/sendf.c
Show outdated Hide outdated tests/libtest/lib1513.c
Show outdated Hide outdated tests/libtest/lib516.c

Nekto89 added some commits Jun 4, 2018

Revert "Fix "Passing NULL after the last typed argument to a variadic…
… function leads to undefined behaviour." in tests."

This reverts commit a7538cf.
@Nekto89

This comment has been minimized.

Show comment
Hide comment
@Nekto89

Nekto89 Jun 5, 2018

Contributor

1 test failed. But before last 3 commits it wasn't failing. They shouldn't change behavior at all.

Contributor

Nekto89 commented Jun 5, 2018

1 test failed. But before last 3 commits it wasn't failing. They shouldn't change behavior at all.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Jun 11, 2018

Member

Correct, that test 1455 has showed up as a failure intermittently lately and is unrelated to your changes.

Member

bagder commented Jun 11, 2018

Correct, that test 1455 has showed up as a failure intermittently lately and is unrelated to your changes.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Jun 11, 2018

Member

Thanks!

Member

bagder commented Jun 11, 2018

Thanks!

@bagder bagder closed this in c45360d Jun 11, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Sep 9, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.