Generated test: add to make clean and fix removal from tarball#2633
Closed
rikardfalkeborn wants to merge 2 commits intocurl:masterfrom
Closed
Generated test: add to make clean and fix removal from tarball#2633rikardfalkeborn wants to merge 2 commits intocurl:masterfrom
rikardfalkeborn wants to merge 2 commits intocurl:masterfrom
Conversation
Contributor
Author
|
Apparently I didn't check the cmake build. Before I try to fix this, is the idea of the PR sound? I think it should be possible to get it to work by modifying tests/libtest/CMakeLists.txt according to the following but I haven't manage to get the Cmake build work locally. |
Member
Absolutely! |
6926ad9 to
a5de789
Compare
Contributor
Author
|
New attempt. The only difference is that in this one I tried to fix the CMake build. |
Since 467da3a, lib1521.c is generated instead of checked in. According to the commit message, the intention was to remove it from the tarball as well. However, it is still present when running make dist. To remove it, add it to nodist_lib1521_SOURCES. This also means there is no need for the manually added dist-rule in the Makefile. Also update CMakelists.txt to handle the fact that we now may have nodist_SOURCES.
This removes the generated lib1521.c when running make clean.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From what I could read in the mentioned commit, it was intended to not include the generated code in the tarball (hence the dist-rule), but it doesn't work (I never bothered figure out why). The size difference of the tarball is 8kB so pretty much negligible.
Also, add it to make clean to add a simple way to remove accidental changes to the generated test.