Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Generated test: add to make clean and fix removal from tarball #2633
From what I could read in the mentioned commit, it was intended to not include the generated code in the tarball (hence the dist-rule), but it doesn't work (I never bothered figure out why). The size difference of the tarball is 8kB so pretty much negligible.
Also, add it to make clean to add a simple way to remove accidental changes to the generated test.
Apparently I didn't check the cmake build. Before I try to fix this, is the idea of the PR sound?
I think it should be possible to get it to work by modifying tests/libtest/CMakeLists.txt according to the following but I haven't manage to get the Cmake build work locally.
Since 467da3a, lib1521.c is generated instead of checked in. According to the commit message, the intention was to remove it from the tarball as well. However, it is still present when running make dist. To remove it, add it to nodist_lib1521_SOURCES. This also means there is no need for the manually added dist-rule in the Makefile. Also update CMakelists.txt to handle the fact that we now may have nodist_SOURCES.