New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maketgz to resolve sed issues on OSX #2660

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@upadhyaym

upadhyaym commented Jun 14, 2018

Curl build uses maketgz to create release tarball and removes the -DEV string in curl version (e.g. 7.58.0-DEV), else -DEV shows up on command line when curl is run. Upstream provided
maketgz works fine on linux but fails on OSX. Problem is with the sed commands that use option -i without an extension. Maketgz expects GNU sed instead of BSD and this simply won't work on OSX. Adding a backup extension .bak after -i fixes this issue

Running the script as is on OSX gives this error:

sed: -e: No such file or directory

Adding a .bak extension resolves it

Overall, maketgz uses lot of stuff from the path and ignores
environment variables. Might be something the upstream team should
consider

Mamta Upadhyay
Fix maketgz to resolve issues on OSX
Curl build uses maketgz to create release tarball and removes
the -DEV string in curl version (e.g. 7.58.0-DEV), else
-DEV shows up on command line when curl is run. Upstream provided
maketgz works fine on linux but fails on OSX. Problem is with the
sed commands that use option -i without an extension. Maketgz expects
GNU sed instead of BSD and this simply won't work on OSX. Adding
a backup extension .bak after -i fixes this issue

Running the script as if on OSX gives this error:

sed: -e: No such file or directory

Adding a .bak extension resolves it

Overall, maketgz uses lot of stuff from the path and ignores
environment variables. Might be something the upstream team should
consider

@bagder bagder added the build label Jun 14, 2018

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Jun 14, 2018

Member

Thanks! Yes this script was never really designed nor intended for wide-spread use... it assumes a sensible build setup working and present.

Member

bagder commented Jun 14, 2018

Thanks! Yes this script was never really designed nor intended for wide-spread use... it assumes a sensible build setup working and present.

@bagder bagder closed this in cf44843 Jun 14, 2018

@upadhyaym

This comment has been minimized.

Show comment
Hide comment
@upadhyaym

upadhyaym Jun 14, 2018

Thanks. We use tagged source for our builds. Unfortunately, tagged sources keep -DEV string in the version. So we have to run maketgz to remove the string

upadhyaym commented Jun 14, 2018

Thanks. We use tagged source for our builds. Unfortunately, tagged sources keep -DEV string in the version. So we have to run maketgz to remove the string

vszakats added a commit to vszakats/curl that referenced this pull request Jun 15, 2018

vszakats added a commit to vszakats/curl that referenced this pull request Jun 15, 2018

vszakats added a commit to vszakats/curl that referenced this pull request Jun 15, 2018

vszakats added a commit to vszakats/curl that referenced this pull request Jun 15, 2018

vszakats added a commit that referenced this pull request Jun 15, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Sep 12, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.