configure: Add dependent libraries after crypto #2684

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@cmeister2
Contributor

cmeister2 commented Jun 26, 2018

The linker is pretty dumb and processes things left to right, keeping a
tally of symbols it hasn't resolved yet. So, we need -ldl to appear
after -lcrypto otherwise the linker won't find the dl functions.


This appears to fix the fuzzer build, but would appreciate an extra set of eyes.

@cmeister2 cmeister2 requested a review from bagder Jun 26, 2018

AC_MSG_CHECKING([OpenSSL linking with -ldl and -lpthread])
- LIBS="$CLEANLIBS -ldl -lpthread -lcrypto"
+ LIBS="$CLEANLIBS -lcrypto -ldl -lpthread"

This comment has been minimized.

@cmeister2

cmeister2 Jun 26, 2018

Contributor

I'm not entirely sure why this suddenly uses CLEANLIBS, where the one above uses LIBS.

@cmeister2

cmeister2 Jun 26, 2018

Contributor

I'm not entirely sure why this suddenly uses CLEANLIBS, where the one above uses LIBS.

This comment has been minimized.

@bagder

bagder Jun 26, 2018

Member

I think maybe the previous one should use CLEANLIBS too, as LIBS already contains "-lcrypto" at that point and it adds it again...

@bagder

bagder Jun 26, 2018

Member

I think maybe the previous one should use CLEANLIBS too, as LIBS already contains "-lcrypto" at that point and it adds it again...

This comment has been minimized.

@cmeister2

cmeister2 Jun 26, 2018

Contributor

Yes. I did wonder about that. Worth trying do you think?

@cmeister2

cmeister2 Jun 26, 2018

Contributor

Yes. I did wonder about that. Worth trying do you think?

This comment has been minimized.

@bagder

bagder Jun 26, 2018

Member

It's not the end of the world, but sure, if you fixup that at the same time as you this fix, I approve!

@bagder

bagder Jun 26, 2018

Member

It's not the end of the world, but sure, if you fixup that at the same time as you this fix, I approve!

This comment has been minimized.

@cmeister2

cmeister2 Jun 26, 2018

Contributor

Done.

@cmeister2

cmeister2 Jun 26, 2018

Contributor

Done.

@bagder bagder added the build label Jun 26, 2018

@bagder

bagder approved these changes Jun 26, 2018

configure: Add dependent libraries after crypto
The linker is pretty dumb and processes things left to right, keeping a
tally of symbols it hasn't resolved yet. So, we need -ldl to appear
after -lcrypto otherwise the linker won't find the dl functions.
@bagder

bagder approved these changes Jun 26, 2018

@cmeister2 cmeister2 closed this in b0a365f Jun 27, 2018

@cmeister2 cmeister2 deleted the cmeister2/openssllinkerorder branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment