Update confusing example of using CURLINFO_TLS_SSL_PTR#2690
Closed
AdrianPeniak wants to merge 2 commits intocurl:masterfrom
Closed
Update confusing example of using CURLINFO_TLS_SSL_PTR#2690AdrianPeniak wants to merge 2 commits intocurl:masterfrom
AdrianPeniak wants to merge 2 commits intocurl:masterfrom
Conversation
Previous example was little bit confusing, because SSL* structure (or other "in use" SSL connection pointer) are not accessible after transfer, therefore working with raw TLS library specific pointer should be done during transfer.
AdrianPeniak
changed the title
bagder
approved these changes
Jun 28, 2018
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Yeah, this is better. Two nits:
- it mixes code-style (brace position)
- I think we can skip the (void) lines to shorten it
Unify brackets & remove unused (void) lines
Member
|
Thanks! (I edited it slightly before merge) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous example was little bit confusing, because SSL* structure (or other "in use" SSL connection pointer) are not accessible after transfer, therefore working with raw TLS library specific pointer should be done during transfer.