Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipelining: deprecated #2705

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@bagder
Copy link
Member

commented Jul 2, 2018

Transparently. The related curl_multi_setopt() options all still return OK when pipelining is selected.

To re-enable the support, the single line change in lib/multi.c needs to be reverted.

See DEPRECATE for the explanation and plan.

@jay

This comment has been minimized.

Copy link
Member

commented Jul 4, 2018

Cisco is a major vendor that has used pipelining, I believe that was discussed here or IRC or somewhere I don't remember. Also from professional experience Samsung is another. What they're using it in I don't know. This isn't an objection just pointing out there are companies that I assume are still using it.

@bagder

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2018

Sure, and that's a reason why we have a long period from us just disabling the feature until it gets removed so that people can notice and speak up and object if they feel this is a crucial feature for them.

@jeroen

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2018

Just noting that this would make the naming of the CURLMOPT_PIPELINING option more confusing as this option is still used to enable http/2 via CURLPIPE_MULTIPLEX I suppose?

Perhaps CURLMOPT_PIPELINING should be renamed to something else if "pipelining" is deprecated.

@bagder

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2018

Perhaps CURLMOPT_PIPELINING should be renamed to something else if "pipelining" is deprecated

Sure, maybe we should consider adding an alias for the name, but with #2709 the option itself will be less needed and then I'm not sure it is as important anymore...

@bagder bagder force-pushed the bagder/deprecate-pipelining-step-1 branch from 8296b89 to e9444fe Aug 23, 2018

bagder added some commits Aug 27, 2018

pipelining: deprecated
Transparently. The related curl_multi_setopt() options all still returns OK
when pipelining is selected.

To re-enable the support, the single line change in lib/multi.c needs to be
reverted.

@bagder bagder force-pushed the bagder/deprecate-pipelining-step-1 branch from e9444fe to c46edab Aug 28, 2018

@bagder bagder closed this in f7208df Sep 5, 2018

@bagder bagder deleted the bagder/deprecate-pipelining-step-1 branch Sep 7, 2018

falconindy added a commit to falconindy/curl that referenced this pull request Sep 10, 2018

pipelining: deprecated
Transparently. The related curl_multi_setopt() options all still returns
OK when pipelining is selected.

To re-enable the support, the single line change in lib/multi.c needs to
be reverted.

See docs/DEPRECATE.md

Closes curl#2705

@lock lock bot locked as resolved and limited conversation to collaborators Dec 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.