New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable multiplexing and HTTP/2 when over HTTPS - by default #2709

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@bagder
Copy link
Member

bagder commented Jul 5, 2018

Starting 7.62.0, multiplexing is enabled by default in multi handles.

Enable multiplexing by default mail

Enable HTTP/2 when using HTTPS, by default mail

@bagder bagder changed the title multiplex: enable by default enable multiplexing and HTTP/2 when over HTTPS - by default Jul 5, 2018

@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Jul 9, 2018

Prerequisites: both #2674 and #2688 need to be fixed accordingly first.

@bagder bagder referenced this pull request Jul 20, 2018

Closed

pipelining: deprecated #2705

bagder added some commits Jul 5, 2018

multiplex: enable by default
Starting 7.62.0, multiplexing is enabled by default in multi handles.

@bagder bagder force-pushed the bagder/multiplex-by-default branch from 93a484d to 8f214ae Aug 23, 2018

@bagder bagder closed this in 25fd105 Sep 5, 2018

@bagder bagder deleted the bagder/multiplex-by-default branch Sep 5, 2018

falconindy added a commit to falconindy/curl that referenced this pull request Sep 10, 2018

@dscho

This comment has been minimized.

Copy link
Contributor

dscho commented Dec 4, 2018

@bagder one of our users is facing a problem with this change, and maybe you have a quick idea how to solve this.

Apparently NTLM is incompatible with HTTP/2 (I could not find any official documentation, but this comment on the Firefox bug tracker seems to suggest so).

However, with the new default in libcurl 7.62.0, it seems that we're upgrading to HTTP/2 before realizing that we cannot authenticate via NTLM, and then the connection is closed without success.

Any idea how to fix this neatly?

@ljani

This comment has been minimized.

Copy link

ljani commented Dec 5, 2018

Here's the official documentation bit at least with IIS 10:

Windows authentication (NTLM/Kerberos/Negotiate) is not supported with HTTP/2. In this case IIS will fall back to HTTP/1.1.

@dscho

This comment has been minimized.

Copy link
Contributor

dscho commented Dec 5, 2018

@ljani indeed. The problem is that cURL somehow does not fall back to HTTP/1.1...

@dscho

This comment has been minimized.

Copy link
Contributor

dscho commented Dec 5, 2018

I should have known better than to clutter this here, closed ticket with a new concern, so I opened a new ticket: #3341. Let's discuss this over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment